Only initialize a std::string with data when the data has len > 0.

Only initialize a std::string with data when the data has len > 0.

When glGet[Shader|Program]InfoLog returned a zero-length info log,
std::string would be initialized with garbage data.  std::vector::data
has an undefined return value when the size of the vector is 0.

BUG=602737
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2693553002
Cr-Commit-Position: refs/heads/master@{#449867}
Committed: https://chromium.googlesource.com/chromium/src/+/4a503e85de502aa541cae933a6cc7b6586b5b9cf

[Geoff Lang, 2017-02-10 20:37:32]

Description was changed from

==========
Only initialize a std::string with data when the data has len > 0.

When glGet[Shader|Program]InfoLog returned a zero-length info log,
std::string would be initialized with garbage data.  std::vector::data
has an undefined return value when the size of the vector is 0.

BUG=602737
==========

to

==========
Only initialize a std::string with data when the data has len > 0.

When glGet[Shader|Program]InfoLog returned a zero-length info log,
std::string would be initialized with garbage data.  std::vector::data
has an undefined return value when the size of the vector is 0.

BUG=602737
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Geoff Lang, 2017-02-10 20:42:01]

Description was changed from

==========
Only initialize a std::string with data when the data has len > 0.

When glGet[Shader|Program]InfoLog returned a zero-length info log,
std::string would be initialized with garbage data.  std::vector::data
has an undefined return value when the size of the vector is 0.

BUG=602737
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Only initialize a std::string with data when the data has len > 0.

When glGet[Shader|Program]InfoLog returned a zero-length info log,
std::string would be initialized with garbage data.  std::vector::data
has an undefined return value when the size of the vector is 0.

BUG=602737
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Geoff Lang, 2017-02-10 20:42:01]

geofflang@chromium.org changed reviewers:
+ zmo@chromium.org

[Geoff Lang, 2017-02-10 20:42:06]

The CQ bit was checked by geofflang@chromium.org to run a CQ dry run

[Geoff Lang, 2017-02-10 20:42:11]

PTAL

[commit-bot: I haz the power, 2017-02-10 20:43:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhenyao Mo, 2017-02-10 20:54:33]

On 2017/02/10 20:42:11, Geoff Lang wrote:
> PTAL

lgtm

[commit-bot: I haz the power, 2017-02-10 22:35:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 22:35:11]

Dry run: This issue passed the CQ dry run.

[Geoff Lang, 2017-02-11 16:59:37]

The CQ bit was checked by geofflang@chromium.org

[commit-bot: I haz the power, 2017-02-11 16:59:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-11 17:07:54]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486832377307210, "parent_rev":
"ec9b0ca3bf54e11d3e9d206f24845c32e77c5385", "commit_rev":
"4a503e85de502aa541cae933a6cc7b6586b5b9cf"}

[commit-bot: I haz the power, 2017-02-11 17:08:30]

Description was changed from

==========
Only initialize a std::string with data when the data has len > 0.

When glGet[Shader|Program]InfoLog returned a zero-length info log,
std::string would be initialized with garbage data.  std::vector::data
has an undefined return value when the size of the vector is 0.

BUG=602737
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Only initialize a std::string with data when the data has len > 0.

When glGet[Shader|Program]InfoLog returned a zero-length info log,
std::string would be initialized with garbage data.  std::vector::data
has an undefined return value when the size of the vector is 0.

BUG=602737
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2693553002
Cr-Commit-Position: refs/heads/master@{#449867}
Committed:
https://chromium.googlesource.com/chromium/src/+/4a503e85de502aa541cae933a6cc...
==========

[commit-bot: I haz the power, 2017-02-11 17:08:31]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4a503e85de502aa541cae933a6cc...