third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/printing.py - Issue 2693533003: webkitpy: Reworking test chunking for sharding.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/printing.py

Issue 2693533003: webkitpy: Reworking test chunking for sharding. (Closed)

Patch Set: Rebase onto revert-1491143003 Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/printing_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/printing.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/printing.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/printing.py

index 3170b040c9b1f46044fe75f0ad33cefb4660f245..3f281bac6140c347a419e204adc77eb8aed8b0c9 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/printing.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/printing.py

@@ -101,11 +101,14 @@ class Printer(object):

self._print_default('Command line: ' + ' '.join(self._port.driver_cmd_line()))

self._print_default('')

- def print_found(self, num_all_test_files, num_to_run, repeat_each, iterations):

- found_str = 'Found %s; running %d' % (grammar.pluralize('test', num_all_test_files), num_to_run)

+ def print_found(self, num_all_test_files, num_shard_test_files, num_to_run, repeat_each, iterations):

+ found_str = 'Found %s' % grammar.pluralize('test', num_shard_test_files)

+ if num_all_test_files != num_shard_test_files:

+ found_str += ' (total %d)' % num_all_test_files

+ found_str += '; running %d' % num_to_run

if repeat_each * iterations > 1:

found_str += ' (%d times each: --repeat-each=%d --iterations=%d)' % (repeat_each * iterations, repeat_each, iterations)

- found_str += ', skipping %d' % (num_all_test_files - num_to_run)

+ found_str += ', skipping %d' % (num_shard_test_files - num_to_run)

self._print_default(found_str + '.')

def print_expected(self, run_results, tests_with_result_type_callback):