third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py - Issue 2693533003: webkitpy: Reworking test chunking for sharding.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py

Issue 2693533003: webkitpy: Reworking test chunking for sharding. (Closed)

Patch Set: Rebase onto revert-1491143003 Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/printing.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py

index 6d1aee275bbe9cd456738fd60bd1c6a293fe0807..38d7593b7b63757b7e217315929f5e57e9886232 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py

@@ -1174,6 +1174,11 @@ class TestExpectations(object):

model.add_expectation_line(expectation_line)

self._model.merge_model(model)

+ def remove_tests(self, tests_to_remove):

+ for test in self._expectations:

+ if test.name and test.name in tests_to_remove:

+ self.remove_expectation_line(test)

def add_expectations_from_bot(self):

# FIXME: With mode 'very-flaky' and 'maybe-flaky', this will show the expectations entry in the flakiness

# dashboard rows for each test to be whatever the bot thinks they should be. Is this a good thing?