Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2693383004: [mjsunit] Exit on hitting unreachable code instead of throwing (Closed)

Created:
3 years, 10 months ago by gsathya
Modified:
3 years, 10 months ago
Reviewers:
neis
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[mjsunit] Exit on hitting unreachable code instead of throwing Errors are swallowed by promises, so just exit with stack trace. Review-Url: https://codereview.chromium.org/2693383004 Cr-Commit-Position: refs/heads/master@{#43254} Committed: https://chromium.googlesource.com/v8/v8/+/7ee77b9be602176325701659c4c38b5204b609e3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M test/mjsunit/es6/promises.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
gsathya
There's probably a better, more involved fix for this, but this is good enough for ...
3 years, 10 months ago (2017-02-16 13:37:22 UTC) #3
neis
lgtm
3 years, 10 months ago (2017-02-16 14:24:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2693383004/1
3 years, 10 months ago (2017-02-16 14:24:16 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 14:47:02 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/7ee77b9be602176325701659c4c38b5204b...

Powered by Google App Engine
This is Rietveld 408576698