chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html - Issue 2693373002: [MD Settings] Add title to show/hide password button.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html

Issue 2693373002: [MD Settings] Add title to show/hide password button. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/app/settings_strings.grdp ('K') | « chrome/browser/resources/settings/passwords_and_forms_page/compiled_resources2.gyp ('k') | chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.js » ('j') | chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html

diff --git a/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html b/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html

index ebe8619e6bed30de36321e4c015f3102b8a7d9d8..b1056513ec852e3af80c021b5fa63f24e984f0fa 100644

--- a/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html

+++ b/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html

@@ -1,4 +1,5 @@

+<link rel="import" href="chrome://resources/html/i18n_behavior.html">

@@ -38,7 +39,8 @@

value="[[getPassword_(item, password)]]" readonly>

</paper-input>

<paper-icon-button id="showPasswordButton"

- icon="settings:visibility" on-tap="onShowPasswordButtonTap_">

+ icon="settings:visibility" on-tap="onShowPasswordButtonTap_"

+ title="[[showPasswordTitle_(password)]]">

dschuyler 2017/02/15 20:12:15 We now have $i18nPolymer, yay! Consider changing t

hcarmona 2017/02/15 21:52:11 Done.

</paper-icon-button>

</div>