[MD Settings] Add title to show/hide password button.

chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview 'password-edit-dialog' is the dialog that allows showing a
  *     saved password.
  */
 
 (function() {
 'use strict';
 
 Polymer({
   is: 'password-edit-dialog',
 
+  behaviors: [I18nBehavior],

[dschuyler, 2017/02/15 20:12:15]

With $i18nPolymer this behavior can be removed.

[hcarmona, 2017/02/15 21:52:11]

Done.

+
   properties: {
     /**
      * The password that is being displayed.
      * @type {!chrome.passwordsPrivate.PasswordUiEntry}
      */
     item: Object,
 
     /** Holds the plaintext password when requested. */
     password: String,
   },
@@ skipping 13 matching lines @@
    * Gets the password input's type. Should be 'text' when password is visible
    * and 'password' when it's not.
    * @param {string} password
    * @private
    */
   getPasswordInputType_: function(password) {
     return password ? 'text' : 'password';
   },
 
   /**
+   * Gets the title text for the show/hide icon.
+   * @param {string} password
+   * @private
+   */
+  showPasswordTitle_: function(password) {
+    return password ? this.i18n('hidePassword') : this.i18n('showPassword');

[dschuyler, 2017/02/15 20:12:15]

With $i18nPolymer this could become:
showPasswordTitle_: function(password, hide, show) {
  return password ? hide : show;

[hcarmona, 2017/02/15 21:52:11]

Sweet. Done.

+  },
+
+  /**
    * Gets the text of the password. Will use the value of |password| unless it
    * cannot be shown, in which case it will be spaces.
    * @param {!chrome.passwordsPrivate.PasswordUiEntry} item
    * @param {string} password
    * @private
    */
   getPassword_: function(item, password) {
     if (password)
       return password;
     return item ? ' '.repeat(item.numCharactersInPassword) : '';
@@ skipping 22 matching lines @@
   /**
    * Handler for tapping the save button.
    * @private
    */
   onSaveButtonTap_: function() {
     // TODO(hcarmona): what to save?
     this.close();
   },
 });
 })();