Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2693353002:
WIP shutdown handler for better stats dumping (Closed)
|
Created:
3 years, 10 months ago by Camillo Bruni Modified:
3 years, 9 months ago CC:
chromium-reviews, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[renderer] Call V8 DumpAndResetStats in RenderThreadImpl::Shutdown
This gives V8 a chance to dump low-level stats to reduce debugging and
investigation overhead for V8 devs.
Depends on V8 CL: https://chromium-review.googlesource.com/c/452338/
Review-Url: https://codereview.chromium.org/2693353002
Cr-Commit-Position: refs/heads/master@{#458040}
Committed: https://chromium.googlesource.com/chromium/src/+/a3f655ba2cf72c76d87bdd7ae6c378a7e3601211
Patch Set 1 #Patch Set 2 : adding shutdown hook #Patch Set 3 : use DumpAndResetStats #Messages
Total messages: 22 (12 generated)
Description was changed from ========== WIP shutdown handler for better stats dumping BUG= ========== to ========== [renderer] Call V8 Isolate LightweightShutdown This gives V8 a chance to dump low-level stats and reduces debugging and investigation overhead for V8 devs. ==========
Description was changed from ========== [renderer] Call V8 Isolate LightweightShutdown This gives V8 a chance to dump low-level stats and reduces debugging and investigation overhead for V8 devs. ========== to ========== [renderer] Call V8 Isolate LightweightShutdown This gives V8 a chance to dump low-level stats and reduces debugging and investigation overhead for V8 devs. Depends on V8 CL: https://chromium-review.googlesource.com/c/452338/ ==========
cbruni@chromium.org changed reviewers: + esprehn@chromium.org
PTAL
I'm nervous this will just become a dumping ground for clean up code inside v8 if folks expect this to get called. Can we guard it with a special flag instead so under normal chrome operation this call is never made?
esprehn@chromium.org changed reviewers: + haraken@chromium.org
On 2017/03/09 at 12:32:07, esprehn wrote: > I'm nervous this will just become a dumping ground for clean up code inside v8 if folks expect this to get called. Can we guard it with a special flag instead so under normal chrome operation this call is never made? I'll renamed it to DumpAndResetStats, which should make the intentions very clear. And we can guard it being --no-sandbox .
PTAL again
lgtm
LGTM
Btw your change description needs updating. :)
Description was changed from ========== [renderer] Call V8 Isolate LightweightShutdown This gives V8 a chance to dump low-level stats and reduces debugging and investigation overhead for V8 devs. Depends on V8 CL: https://chromium-review.googlesource.com/c/452338/ ========== to ========== [renderer] Call V8 DumpAndResetStats in RenderThreadImpl::Shutdown This gives V8 a chance to dump low-level stats to reduce debugging and investigation overhead for V8 devs. Depends on V8 CL: https://chromium-review.googlesource.com/c/452338/ ==========
The CQ bit was checked by cbruni@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by cbruni@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490002075266950,
"parent_rev": "d81303c8e08b491495d5fc425aaeb191f7be3418", "commit_rev":
"a3f655ba2cf72c76d87bdd7ae6c378a7e3601211"}
Message was sent while issue was closed.
Description was changed from ========== [renderer] Call V8 DumpAndResetStats in RenderThreadImpl::Shutdown This gives V8 a chance to dump low-level stats to reduce debugging and investigation overhead for V8 devs. Depends on V8 CL: https://chromium-review.googlesource.com/c/452338/ ========== to ========== [renderer] Call V8 DumpAndResetStats in RenderThreadImpl::Shutdown This gives V8 a chance to dump low-level stats to reduce debugging and investigation overhead for V8 devs. Depends on V8 CL: https://chromium-review.googlesource.com/c/452338/ Review-Url: https://codereview.chromium.org/2693353002 Cr-Commit-Position: refs/heads/master@{#458040} Committed: https://chromium.googlesource.com/chromium/src/+/a3f655ba2cf72c76d87bdd7ae6c3... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/a3f655ba2cf72c76d87bdd7ae6c3... |
