Don't use a global share group for the passthrough command buffer contexts.

Don't use a global share group for the passthrough command buffer contexts.

Use ANGLE's EGL_ANGLE_display_texture_share_group extension to share textures
accross context share groups.

Because contexts are no longer all in the same share group, request context
versions to match their usage.

BUG=angleproject:1639
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2693333003
Cr-Commit-Position: refs/heads/master@{#452063}
Committed: https://chromium.googlesource.com/chromium/src/+/3ab039df2d54013b3b72a450928ea65501695569

[Geoff Lang, 2017-02-15 21:39:17]

Description was changed from

==========
Don't use a global share group for the passthrough command buffer contexts.

Use ANGLE's EGL_ANGLE_display_texture_share_group extension to share textures
accross context share groups.

Because contexts are no longer all in the same share group, request context
versions to match their usage.

BUG=angleproject:1639
==========

to

==========
Don't use a global share group for the passthrough command buffer contexts.

Use ANGLE's EGL_ANGLE_display_texture_share_group extension to share textures
accross context share groups.

Because contexts are no longer all in the same share group, request context
versions to match their usage.

BUG=angleproject:1639
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Geoff Lang, 2017-02-15 21:39:26]

The CQ bit was checked by geofflang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 21:40:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 23:21:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 23:21:48]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Geoff Lang, 2017-02-16 16:00:30]

The CQ bit was checked by geofflang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 16:00:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Geoff Lang, 2017-02-16 16:04:50]

geofflang@chromium.org changed reviewers:
+ jbauman@chromium.org, zmo@chromium.org

[Geoff Lang, 2017-02-16 16:04:51]

PTAL, this change enables a new ANGLE extension that allows Chrome's contexts to
be in separate share groups but still share textures for mailboxes.

This lets the passthrough command buffer create ES2 or ES3 contexts depending on
what's requested instead of always creating ES3 and emulating ES2 for WebGL1.

[commit-bot: I haz the power, 2017-02-16 16:38:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 16:38:58]

Dry run: This issue passed the CQ dry run.

[Zhenyao Mo, 2017-02-16 22:43:11]

lgtm

https://codereview.chromium.org/2693333003/diff/1/ui/gl/gl_context_egl.cc
File ui/gl/gl_context_egl.cc (right):

https://codereview.chromium.org/2693333003/diff/1/ui/gl/gl_context_egl.cc#new...
ui/gl/gl_context_egl.cc:77: context_client_minor_version = 0;
Should we fail here and let the caller decides what they want to do? They have
the option of going for ES2 or something else.

[jbauman, 2017-02-17 21:30:44]

lgtm

[Geoff Lang, 2017-02-21 20:35:32]

https://codereview.chromium.org/2693333003/diff/1/ui/gl/gl_context_egl.cc
File ui/gl/gl_context_egl.cc (right):

https://codereview.chromium.org/2693333003/diff/1/ui/gl/gl_context_egl.cc#new...
ui/gl/gl_context_egl.cc:77: context_client_minor_version = 0;
On 2017/02/16 22:43:11, Zhenyao Mo wrote:
> Should we fail here and let the caller decides what they want to do? They have
> the option of going for ES2 or something else.

Yea, I think it would make sense to first ask to see if it's possible to create
a context version instead of creating a lower version and then destroying it
after when it doesn't meet the requirements.  Going to save that for another CL
though since I don't want to change the behaviour here.

[Geoff Lang, 2017-02-21 20:35:38]

The CQ bit was checked by geofflang@chromium.org

[commit-bot: I haz the power, 2017-02-21 20:36:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 21:53:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 21:53:05]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Geoff Lang, 2017-02-22 14:57:47]

The CQ bit was checked by geofflang@chromium.org

[commit-bot: I haz the power, 2017-02-22 14:58:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 15:34:03]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487775467286350, "parent_rev":
"bdb93c7b5c6c6568e5ce7c8825d3d28b74a23ddb", "commit_rev":
"3ab039df2d54013b3b72a450928ea65501695569"}

[commit-bot: I haz the power, 2017-02-22 15:34:41]

Description was changed from

==========
Don't use a global share group for the passthrough command buffer contexts.

Use ANGLE's EGL_ANGLE_display_texture_share_group extension to share textures
accross context share groups.

Because contexts are no longer all in the same share group, request context
versions to match their usage.

BUG=angleproject:1639
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Don't use a global share group for the passthrough command buffer contexts.

Use ANGLE's EGL_ANGLE_display_texture_share_group extension to share textures
accross context share groups.

Because contexts are no longer all in the same share group, request context
versions to match their usage.

BUG=angleproject:1639
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2693333003
Cr-Commit-Position: refs/heads/master@{#452063}
Committed:
https://chromium.googlesource.com/chromium/src/+/3ab039df2d54013b3b72a450928e...
==========

[commit-bot: I haz the power, 2017-02-22 15:34:42]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3ab039df2d54013b3b72a450928e...