Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2693273002: Handle GLES2::ConsumeTextureCHROMIUM consuming the currently bound texture. (Closed)

Created:
3 years, 10 months ago by vmiura
Modified:
3 years, 10 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, piman+watch_chromium.org, Ken Russell (switch to Gerrit)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle GLES2::ConsumeTextureCHROMIUM consuming the currently bound texture. If the consumed mailbox corresponded to the currently bound texture, the same texture was first deleted, then consumed causing use-after-free. R=zmo@chromium.org BUG=690216 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2693273002 Cr-Commit-Position: refs/heads/master@{#450806} Committed: https://chromium.googlesource.com/chromium/src/+/307befe4b9981bcd19c4f2b2ca189cca588a7d8e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
vmiura
zmo: PTAL kbr: FYI
3 years, 10 months ago (2017-02-15 03:45:46 UTC) #3
Zhenyao Mo
On 2017/02/15 03:45:46, vmiura wrote: > zmo: PTAL > kbr: FYI LGTM It's surprising such ...
3 years, 10 months ago (2017-02-15 18:36:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2693273002/1
3 years, 10 months ago (2017-02-15 19:43:18 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 21:28:53 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/307befe4b9981bcd19c4f2b2ca18...

Powered by Google App Engine
This is Rietveld 408576698