Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 2693263003: Release RTCPeerConnection PowerSaveBlock on process exit. (Closed)

Created:
3 years, 10 months ago by Guido Urdaneta
Modified:
3 years, 10 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, shrike
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Release RTCPeerConnection PowerSaveBlock on process exit. Also, do cleanup on RenderProcessExited() instead of RenderProcessHostDestroyed() as the latter can take an indeterminate amount of time to be called. BUG=612294 Review-Url: https://codereview.chromium.org/2693263003 Cr-Commit-Position: refs/heads/master@{#450760} Committed: https://chromium.googlesource.com/chromium/src/+/223163006109b9b54a8421f4ca8139403ad63e0d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M content/browser/webrtc/webrtc_internals.h View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/webrtc/webrtc_internals.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Guido Urdaneta
PTAL
3 years, 10 months ago (2017-02-15 13:57:56 UTC) #3
tommi (sloooow) - chröme
lgtm
3 years, 10 months ago (2017-02-15 16:10:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2693263003/1
3 years, 10 months ago (2017-02-15 16:19:37 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 19:15:45 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/223163006109b9b54a8421f4ca81...

Powered by Google App Engine
This is Rietveld 408576698