|
|
Descriptionupdate webgl2 expectations
BUG=679682
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2693263002
Cr-Commit-Position: refs/heads/master@{#450863}
Committed: https://chromium.googlesource.com/chromium/src/+/b4b2248909ab2dfa203f32ac1a33acb7aa66ed0c
Patch Set 1 #
Messages
Total messages: 23 (13 generated)
Description was changed from ========== update webgl2 expectation BUG= ========== to ========== update webgl2 expectation BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== update webgl2 expectation BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== update webgl2 expectation BUG=679682 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
yunchao.he@intel.com changed reviewers: + kbr@chromium.org, qiankun.miao@intel.com, zmo@chromium.org
PTAL. Thanks! The trybots didn't test against Mac NVIDIA, but I'd like to remove it too. If anyone find the removed tests failed on Mac NVIDIA, please add it back. If not, we can close the issue at https://crbug.com/679682
Description was changed from ========== update webgl2 expectation BUG=679682 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== update webgl2 expectations BUG=679682 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
On 2017/02/15 07:03:50, yunchao wrote: > PTAL. Thanks! > > The trybots didn't test against Mac NVIDIA, but I'd like to remove it too. If > anyone find the removed tests failed on Mac NVIDIA, please add it back. If not, > we can close the issue at https://crbug.com/679682 LGTM Please watch https://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%20Retina%20Release... and see if these tests pass.
On 2017/02/15 18:44:52, Zhenyao Mo wrote: > On 2017/02/15 07:03:50, yunchao wrote: > > PTAL. Thanks! > > > > The trybots didn't test against Mac NVIDIA, but I'd like to remove it too. If > > anyone find the removed tests failed on Mac NVIDIA, please add it back. If > not, > > we can close the issue at https://crbug.com/679682 > > LGTM > > Please watch > https://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%20Retina%20Release... > and see if these tests pass. OK. Thanks for this info, Zhenyao. Merging now...
The CQ bit was checked by yunchao.he@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1487213079718350, "parent_rev": "7009b6753eccab02d997e91702bccb9041442a5c", "commit_rev": "b4b2248909ab2dfa203f32ac1a33acb7aa66ed0c"}
Message was sent while issue was closed.
Description was changed from ========== update webgl2 expectations BUG=679682 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== update webgl2 expectations BUG=679682 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2693263002 Cr-Commit-Position: refs/heads/master@{#450863} Committed: https://chromium.googlesource.com/chromium/src/+/b4b2248909ab2dfa203f32ac1a33... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/b4b2248909ab2dfa203f32ac1a33...
Message was sent while issue was closed.
On 2017/02/15 18:44:52, Zhenyao Mo wrote: > On 2017/02/15 07:03:50, yunchao wrote: > > PTAL. Thanks! > > > > The trybots didn't test against Mac NVIDIA, but I'd like to remove it too. If > > anyone find the removed tests failed on Mac NVIDIA, please add it back. If > not, > > we can close the issue at https://crbug.com/679682 > > LGTM > > Please watch > https://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%20Retina%20Release... > and see if these tests pass. Mac NVIDIA FYI bot is green: https://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%20Retina%20Release...
Message was sent while issue was closed.
On 2017/02/16 06:41:59, yunchao wrote: > On 2017/02/15 18:44:52, Zhenyao Mo wrote: > > On 2017/02/15 07:03:50, yunchao wrote: > > > PTAL. Thanks! > > > > > > The trybots didn't test against Mac NVIDIA, but I'd like to remove it too. > If > > > anyone find the removed tests failed on Mac NVIDIA, please add it back. If > > not, > > > we can close the issue at https://crbug.com/679682 > > > > LGTM > > > > Please watch > > > https://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%20Retina%20Release... > > and see if these tests pass. > > Mac NVIDIA FYI bot is green: > https://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%20Retina%20Release... Please re-disable here: https://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%20Pro%20Release%20... ('amd', 0x679e)
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2700043003/ by ccameron@chromium.org. The reason for reverting is: These tests are failing on GPU FYI bots. https://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%20Pro%20Release%20.... |