Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2693253002: MD Settings: Restore Search engines table headers. (Closed)

Created:
3 years, 10 months ago by dpapad
Modified:
3 years, 10 months ago
Reviewers:
tommycli
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Restore Search engines table headers. BUG=619790 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2693253002 Cr-Commit-Position: refs/heads/master@{#450800} Committed: https://chromium.googlesource.com/chromium/src/+/13ff49ec46586eb4aa206226dcf3bef5cf02d5b4

Patch Set 1 #

Patch Set 2 : fx tests #

Messages

Total messages: 16 (12 generated)
dpapad
Before/after screenshots at http://imgur.com/a/NV7ku.
3 years, 10 months ago (2017-02-15 02:57:48 UTC) #8
tommycli
lgtm thanks!
3 years, 10 months ago (2017-02-15 19:25:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2693253002/40001
3 years, 10 months ago (2017-02-15 20:09:03 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 21:20:24 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/13ff49ec46586eb4aa206226dcf3...

Powered by Google App Engine
This is Rietveld 408576698