Revert of Add ChildMemoryCoordinator::PurgeMemory()

Revert of Add ChildMemoryCoordinator::PurgeMemory() (patchset #2 id:20001 of https://codereview.chromium.org/2669323002/ )

Reason for revert:
Appears to be the root cause of crbug.com/692509 (renderer crashes in RenderThreadImpl::OnProcessPurgeAndSuspend) - although the timeline doesn't match up, the change to RenderThreadImpl appears incorrect by inspection (see my comment in the original CL).

Original issue's description:
> Add ChildMemoryCoordinator::PurgeMemory()
> 
> In crrev.com/2655083003 we added OnPurgeMemory() to
> MemoryCoordinatorClient and we are moving purging logic from
> OnMemoryStateChange() to OnPurgeMemory(). To make this transition easy,
> this CL adds PurgeMemory() to ChildMemoryCoordinator. This method calls
> both OnPurgeMemory() and OnMemoryStateChange(SUSPENDED). After purging
> logic in all clients move to OnPurgeMemory(), we can remove
> OnMemoryStateChange() call.
> 
> BUG=684287
> 
> Review-Url: https://codereview.chromium.org/2669323002
> Cr-Commit-Position: refs/heads/master@{#448475}
> Committed: https://chromium.googlesource.com/chromium/src/+/110841cafec3a76ab7446dc7c59107572a2fc68f

NOTRY=true
TBR=tasak@google.com,jam@chromium.org,haraken@chromium.org,bashi@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=684287
Review-Url: https://codereview.chromium.org/2693223003
Cr-Commit-Position: refs/heads/master@{#450859}
Committed: https://chromium.googlesource.com/chromium/src/+/c80d2d2b0fcceac67a16bf6ffb516ba5c0023230

[Wez, 2017-02-15 22:48:06]

The CQ bit was checked by wez@chromium.org

[Wez, 2017-02-15 22:48:07]

Created Revert of Add ChildMemoryCoordinator::PurgeMemory()

[commit-bot: I haz the power, 2017-02-15 22:49:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 22:54:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 22:54:39]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Wez, 2017-02-15 23:08:05]

The CQ bit was checked by wez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 23:08:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2017-02-15 23:38:38]

LGTM to revert

[commit-bot: I haz the power, 2017-02-16 00:19:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 00:19:51]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Wez, 2017-02-16 00:45:45]

The CQ bit was checked by wez@chromium.org

[commit-bot: I haz the power, 2017-02-16 00:47:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bashi, 2017-02-16 00:51:29]

LGTM. Thanks wez@ for reverting. I'll take a look.

[commit-bot: I haz the power, 2017-02-16 01:12:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 01:12:31]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[Wez, 2017-02-16 01:38:33]

The CQ bit was checked by wez@chromium.org

[commit-bot: I haz the power, 2017-02-16 01:40:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 02:49:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 02:49:36]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[bashi, 2017-02-16 02:53:05]

Description was changed from

==========
Revert of Add ChildMemoryCoordinator::PurgeMemory() (patchset #2 id:20001 of
https://codereview.chromium.org/2669323002/ )

Reason for revert:
Appears to be the root cause of crbug.com/692509 (renderer crashes in
RenderThreadImpl::OnProcessPurgeAndSuspend) - although the timeline doesn't
match up, the change to RenderThreadImpl appears incorrect by inspection (see my
comment in the original CL).

Original issue's description:
> Add ChildMemoryCoordinator::PurgeMemory()
> 
> In crrev.com/2655083003 we added OnPurgeMemory() to
> MemoryCoordinatorClient and we are moving purging logic from
> OnMemoryStateChange() to OnPurgeMemory(). To make this transition easy,
> this CL adds PurgeMemory() to ChildMemoryCoordinator. This method calls
> both OnPurgeMemory() and OnMemoryStateChange(SUSPENDED). After purging
> logic in all clients move to OnPurgeMemory(), we can remove
> OnMemoryStateChange() call.
> 
> BUG=684287
> 
> Review-Url: https://codereview.chromium.org/2669323002
> Cr-Commit-Position: refs/heads/master@{#448475}
> Committed:
https://chromium.googlesource.com/chromium/src/+/110841cafec3a76ab7446dc7c591...

TBR=tasak@google.com,jam@chromium.org,haraken@chromium.org,bashi@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=684287
==========

to

==========
Revert of Add ChildMemoryCoordinator::PurgeMemory() (patchset #2 id:20001 of
https://codereview.chromium.org/2669323002/ )

Reason for revert:
Appears to be the root cause of crbug.com/692509 (renderer crashes in
RenderThreadImpl::OnProcessPurgeAndSuspend) - although the timeline doesn't
match up, the change to RenderThreadImpl appears incorrect by inspection (see my
comment in the original CL).

Original issue's description:
> Add ChildMemoryCoordinator::PurgeMemory()
> 
> In crrev.com/2655083003 we added OnPurgeMemory() to
> MemoryCoordinatorClient and we are moving purging logic from
> OnMemoryStateChange() to OnPurgeMemory(). To make this transition easy,
> this CL adds PurgeMemory() to ChildMemoryCoordinator. This method calls
> both OnPurgeMemory() and OnMemoryStateChange(SUSPENDED). After purging
> logic in all clients move to OnPurgeMemory(), we can remove
> OnMemoryStateChange() call.
> 
> BUG=684287
> 
> Review-Url: https://codereview.chromium.org/2669323002
> Cr-Commit-Position: refs/heads/master@{#448475}
> Committed:
https://chromium.googlesource.com/chromium/src/+/110841cafec3a76ab7446dc7c591...

NOTRY=true
TBR=tasak@google.com,jam@chromium.org,haraken@chromium.org,bashi@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=684287
==========

[bashi, 2017-02-16 02:53:10]

The CQ bit was checked by bashi@chromium.org

[commit-bot: I haz the power, 2017-02-16 02:54:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 03:28:26]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1487213590851700,
"parent_rev": "ae7972cadaacc1220283a8536061350046e82a3a", "commit_rev":
"c80d2d2b0fcceac67a16bf6ffb516ba5c0023230"}

[commit-bot: I haz the power, 2017-02-16 03:29:15]

Description was changed from

==========
Revert of Add ChildMemoryCoordinator::PurgeMemory() (patchset #2 id:20001 of
https://codereview.chromium.org/2669323002/ )

Reason for revert:
Appears to be the root cause of crbug.com/692509 (renderer crashes in
RenderThreadImpl::OnProcessPurgeAndSuspend) - although the timeline doesn't
match up, the change to RenderThreadImpl appears incorrect by inspection (see my
comment in the original CL).

Original issue's description:
> Add ChildMemoryCoordinator::PurgeMemory()
> 
> In crrev.com/2655083003 we added OnPurgeMemory() to
> MemoryCoordinatorClient and we are moving purging logic from
> OnMemoryStateChange() to OnPurgeMemory(). To make this transition easy,
> this CL adds PurgeMemory() to ChildMemoryCoordinator. This method calls
> both OnPurgeMemory() and OnMemoryStateChange(SUSPENDED). After purging
> logic in all clients move to OnPurgeMemory(), we can remove
> OnMemoryStateChange() call.
> 
> BUG=684287
> 
> Review-Url: https://codereview.chromium.org/2669323002
> Cr-Commit-Position: refs/heads/master@{#448475}
> Committed:
https://chromium.googlesource.com/chromium/src/+/110841cafec3a76ab7446dc7c591...

NOTRY=true
TBR=tasak@google.com,jam@chromium.org,haraken@chromium.org,bashi@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=684287
==========

to

==========
Revert of Add ChildMemoryCoordinator::PurgeMemory() (patchset #2 id:20001 of
https://codereview.chromium.org/2669323002/ )

Reason for revert:
Appears to be the root cause of crbug.com/692509 (renderer crashes in
RenderThreadImpl::OnProcessPurgeAndSuspend) - although the timeline doesn't
match up, the change to RenderThreadImpl appears incorrect by inspection (see my
comment in the original CL).

Original issue's description:
> Add ChildMemoryCoordinator::PurgeMemory()
> 
> In crrev.com/2655083003 we added OnPurgeMemory() to
> MemoryCoordinatorClient and we are moving purging logic from
> OnMemoryStateChange() to OnPurgeMemory(). To make this transition easy,
> this CL adds PurgeMemory() to ChildMemoryCoordinator. This method calls
> both OnPurgeMemory() and OnMemoryStateChange(SUSPENDED). After purging
> logic in all clients move to OnPurgeMemory(), we can remove
> OnMemoryStateChange() call.
> 
> BUG=684287
> 
> Review-Url: https://codereview.chromium.org/2669323002
> Cr-Commit-Position: refs/heads/master@{#448475}
> Committed:
https://chromium.googlesource.com/chromium/src/+/110841cafec3a76ab7446dc7c591...

NOTRY=true
TBR=tasak@google.com,jam@chromium.org,haraken@chromium.org,bashi@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=684287

Review-Url: https://codereview.chromium.org/2693223003
Cr-Commit-Position: refs/heads/master@{#450859}
Committed:
https://chromium.googlesource.com/chromium/src/+/c80d2d2b0fcceac67a16bf6ffb51...
==========

[commit-bot: I haz the power, 2017-02-16 03:29:16]

Committed patchset #2 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/c80d2d2b0fcceac67a16bf6ffb51...