Log the error result when observing a registry key fails.

Log the error result when observing a registry key fails.

Logging a warning on failure isn't very helpful without the error code.

BUG=692259
Review-Url: https://codereview.chromium.org/2693223002
Cr-Commit-Position: refs/heads/master@{#450538}
Committed: https://chromium.googlesource.com/chromium/src/+/2884d9bee4a26233c3195f8d05b68aae8277e5c8

[Wez, 2017-02-14 23:16:30]

The CQ bit was checked by wez@chromium.org to run a CQ dry run

[Wez, 2017-02-14 23:17:20]

wez@chromium.org changed reviewers:
+ lazyboy@chromium.org

[commit-bot: I haz the power, 2017-02-14 23:17:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 00:17:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 00:17:31]

Dry run: This issue passed the CQ dry run.

[lazyboy, 2017-02-15 00:19:56]

lgtm

https://codereview.chromium.org/2693223002/diff/1/chrome/browser/extensions/e...
File chrome/browser/extensions/external_registry_loader_win.cc (right):

https://codereview.chromium.org/2693223002/diff/1/chrome/browser/extensions/e...
chrome/browser/extensions/external_registry_loader_win.cc:213: LOG(WARNING) <<
"Error observing HKLM: " << result;
Maybe we should remove logging this and keep only the HKCU warning below?

[Wez, 2017-02-15 00:33:21]

https://codereview.chromium.org/2693223002/diff/1/chrome/browser/extensions/e...
File chrome/browser/extensions/external_registry_loader_win.cc (right):

https://codereview.chromium.org/2693223002/diff/1/chrome/browser/extensions/e...
chrome/browser/extensions/external_registry_loader_win.cc:213: LOG(WARNING) <<
"Error observing HKLM: " << result;
On 2017/02/15 00:19:56, lazyboy wrote:
> Maybe we should remove logging this and keep only the HKCU warning below?

Actually it seems like a legitimate error; IIUC correctly the intention of this
code is simply to watch and read from the key(s), so I think we should probably
fix the call-site to try to open the key just for reading.

WDYT?

[Wez, 2017-02-15 00:33:43]

The CQ bit was checked by wez@chromium.org

[commit-bot: I haz the power, 2017-02-15 00:34:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 01:19:30]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487118823906300, "parent_rev":
"b5c27c8179352f544a6e53647c3465c51c36d257", "commit_rev":
"2884d9bee4a26233c3195f8d05b68aae8277e5c8"}

[commit-bot: I haz the power, 2017-02-15 01:20:24]

Description was changed from

==========
Log the error result when observing a registry key fails.

Logging a warning on failure isn't very helpful without the error code.

BUG=692259
==========

to

==========
Log the error result when observing a registry key fails.

Logging a warning on failure isn't very helpful without the error code.

BUG=692259

Review-Url: https://codereview.chromium.org/2693223002
Cr-Commit-Position: refs/heads/master@{#450538}
Committed:
https://chromium.googlesource.com/chromium/src/+/2884d9bee4a26233c3195f8d05b6...
==========

[commit-bot: I haz the power, 2017-02-15 01:20:25]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2884d9bee4a26233c3195f8d05b6...