Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2693223002: Log the error result when observing a registry key fails. (Closed)

Created:
3 years, 10 months ago by Wez
Modified:
3 years, 10 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Log the error result when observing a registry key fails. Logging a warning on failure isn't very helpful without the error code. BUG=692259 Review-Url: https://codereview.chromium.org/2693223002 Cr-Commit-Position: refs/heads/master@{#450538} Committed: https://chromium.googlesource.com/chromium/src/+/2884d9bee4a26233c3195f8d05b68aae8277e5c8

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M chrome/browser/extensions/external_registry_loader_win.cc View 1 chunk +8 lines, -6 lines 2 comments Download

Messages

Total messages: 13 (8 generated)
Wez
3 years, 10 months ago (2017-02-14 23:17:21 UTC) #3
lazyboy
lgtm https://codereview.chromium.org/2693223002/diff/1/chrome/browser/extensions/external_registry_loader_win.cc File chrome/browser/extensions/external_registry_loader_win.cc (right): https://codereview.chromium.org/2693223002/diff/1/chrome/browser/extensions/external_registry_loader_win.cc#newcode213 chrome/browser/extensions/external_registry_loader_win.cc:213: LOG(WARNING) << "Error observing HKLM: " << result; ...
3 years, 10 months ago (2017-02-15 00:19:56 UTC) #7
Wez
https://codereview.chromium.org/2693223002/diff/1/chrome/browser/extensions/external_registry_loader_win.cc File chrome/browser/extensions/external_registry_loader_win.cc (right): https://codereview.chromium.org/2693223002/diff/1/chrome/browser/extensions/external_registry_loader_win.cc#newcode213 chrome/browser/extensions/external_registry_loader_win.cc:213: LOG(WARNING) << "Error observing HKLM: " << result; On ...
3 years, 10 months ago (2017-02-15 00:33:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2693223002/1
3 years, 10 months ago (2017-02-15 00:34:36 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 01:20:25 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2884d9bee4a26233c3195f8d05b6...

Powered by Google App Engine
This is Rietveld 408576698