Add ChromeDriver test for HTTPS bypass, QUIC smoke test

Add ChromeDriver test for HTTPS bypass, QUIC smoke test

BUG=680559, 680571
Review-Url: https://codereview.chromium.org/2693193004
Cr-Commit-Position: refs/heads/master@{#450491}
Committed: https://chromium.googlesource.com/chromium/src/+/9b27503cadb137969839573333b3a007d0a79eee

[tbansal1, 2017-02-14 19:33:47]

Description was changed from

==========
Add Chrome driver test for HTTPS bypass, QUIC smoke test

BUG=
==========

to

==========
Add ChromeDriver test for HTTPS bypass, QUIC smoke test

BUG=680559,680571
==========

[tbansal1, 2017-02-14 19:42:38]

Patchset #1 (id:1) has been deleted

[tbansal1, 2017-02-14 19:43:03]

tbansal@chromium.org changed reviewers:
+ robertogden@chromium.org

[tbansal1, 2017-02-14 19:43:03]

robertogden: ptal. Thanks.

[Robert Ogden, 2017-02-14 19:54:32]

lgtm % nit

https://codereview.chromium.org/2693193004/diff/20001/tools/chrome_proxy/webd...
File tools/chrome_proxy/webdriver/smoke.py (right):

https://codereview.chromium.org/2693193004/diff/20001/tools/chrome_proxy/webd...
tools/chrome_proxy/webdriver/smoke.py:21: # Ensure Chrome uses DataSaver with
QUIC enabled.
Please stick this method in another class or rename the Incognito class to be
generic to all smoke test.

[tbansal1, 2017-02-14 20:33:21]

tbansal@chromium.org changed reviewers:
+ ryansturm@chromium.org

[tbansal1, 2017-02-14 20:33:21]

robertogden, ryansturm: ptal. Thanks.

https://codereview.chromium.org/2693193004/diff/20001/tools/chrome_proxy/webd...
File tools/chrome_proxy/webdriver/smoke.py (right):

https://codereview.chromium.org/2693193004/diff/20001/tools/chrome_proxy/webd...
tools/chrome_proxy/webdriver/smoke.py:21: # Ensure Chrome uses DataSaver with
QUIC enabled.
On 2017/02/14 19:54:32, Robert Ogden wrote:
> Please stick this method in another class or rename the Incognito class to be
> generic to all smoke test.

Done.

[RyanSturm, 2017-02-14 21:43:25]

lgtm

[tbansal1, 2017-02-14 21:43:58]

The CQ bit was checked by tbansal@chromium.org

[tbansal1, 2017-02-14 21:43:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertogden@chromium.org
Link to the patchset: https://codereview.chromium.org/2693193004/#ps40001
(title: "robertogden's comments")

[commit-bot: I haz the power, 2017-02-14 21:45:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 22:18:36]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487108638171670,
"parent_rev": "f9ea64c0ed3c48a5a875bf1ab6fba4cf32a8fe5e", "commit_rev":
"9b27503cadb137969839573333b3a007d0a79eee"}

[commit-bot: I haz the power, 2017-02-14 22:19:55]

Description was changed from

==========
Add ChromeDriver test for HTTPS bypass, QUIC smoke test

BUG=680559,680571
==========

to

==========
Add ChromeDriver test for HTTPS bypass, QUIC smoke test

BUG=680559,680571

Review-Url: https://codereview.chromium.org/2693193004
Cr-Commit-Position: refs/heads/master@{#450491}
Committed:
https://chromium.googlesource.com/chromium/src/+/9b27503cadb137969839573333b3...
==========

[commit-bot: I haz the power, 2017-02-14 22:19:56]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9b27503cadb137969839573333b3...