Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2693193003: Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests. (Closed)

Created:
3 years, 10 months ago by zakerinasab
Modified:
3 years, 10 months ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests. This change replaces js-test.js assertions with testharness.js assertions. The expectation files are removed as they are not needed anymore. To simplify review and landing, each change corrects at most 10 tests. BUG=639732 Review-Url: https://codereview.chromium.org/2693193003 Cr-Commit-Position: refs/heads/master@{#452084} Committed: https://chromium.googlesource.com/chromium/src/+/cece2b21dec5a8f8695a0bf7743a63a8dae32224

Patch Set 1 #

Patch Set 2 : Corrections #

Total comments: 2

Patch Set 3 : Addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+568 lines, -1188 lines) Patch
M third_party/WebKit/LayoutTests/fast/canvas/canvas-scale-strokePath-shadow.html View 1 chunk +85 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-scale-strokePath-shadow-expected.txt View 1 chunk +0 lines, -57 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-set-properties-with-non-invertible-ctm.html View 1 chunk +70 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-set-properties-with-non-invertible-ctm-expected.txt View 1 chunk +0 lines, -23 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-setTransform.html View 1 chunk +71 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-setTransform-expected.txt View 1 chunk +0 lines, -33 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-shadow.html View 1 chunk +30 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-shadow-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-skia-excessive-size.html View 1 chunk +16 lines, -32 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-skia-excessive-size-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-state-intact-after-putImageData.html View 1 2 1 chunk +28 lines, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-state-intact-after-putImageData-expected.txt View 1 chunk +0 lines, -30 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-stroke-empty-fill.html View 1 chunk +17 lines, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-stroke-empty-fill.js View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-stroke-empty-fill-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-strokePath-alpha-shadow.html View 1 chunk +91 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-strokePath-alpha-shadow-expected.txt View 1 chunk +0 lines, -97 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-strokePath-cap-join.html View 1 chunk +160 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-strokePath-cap-join-expected.txt View 1 chunk +0 lines, -43 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/script-tests/canvas-scale-strokePath-shadow.js View 1 chunk +0 lines, -153 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/script-tests/canvas-set-properties-with-non-invertible-ctm.js View 1 chunk +0 lines, -68 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/script-tests/canvas-setTransform.js View 1 chunk +0 lines, -97 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/script-tests/canvas-shadow.js View 1 chunk +0 lines, -32 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/script-tests/canvas-state-intact-after-putImageData.js View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/script-tests/canvas-strokePath-alpha-shadow.js View 1 chunk +0 lines, -113 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/script-tests/canvas-strokePath-cap-join.js View 1 chunk +0 lines, -252 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/canvas-shadow-expected.txt View 1 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Justin Novosad
lgtm with nit https://codereview.chromium.org/2693193003/diff/40001/third_party/WebKit/LayoutTests/fast/canvas/canvas-state-intact-after-putImageData.html File third_party/WebKit/LayoutTests/fast/canvas/canvas-state-intact-after-putImageData.html (right): https://codereview.chromium.org/2693193003/diff/40001/third_party/WebKit/LayoutTests/fast/canvas/canvas-state-intact-after-putImageData.html#newcode7 third_party/WebKit/LayoutTests/fast/canvas/canvas-state-intact-after-putImageData.html:7: var ctx = document.createElement('canvas').getContext('2d'); indent
3 years, 10 months ago (2017-02-21 21:53:35 UTC) #4
zakerinasab
Comments addressed. https://codereview.chromium.org/2693193003/diff/40001/third_party/WebKit/LayoutTests/fast/canvas/canvas-state-intact-after-putImageData.html File third_party/WebKit/LayoutTests/fast/canvas/canvas-state-intact-after-putImageData.html (right): https://codereview.chromium.org/2693193003/diff/40001/third_party/WebKit/LayoutTests/fast/canvas/canvas-state-intact-after-putImageData.html#newcode7 third_party/WebKit/LayoutTests/fast/canvas/canvas-state-intact-after-putImageData.html:7: var ctx = document.createElement('canvas').getContext('2d'); On 2017/02/21 21:53:35, ...
3 years, 10 months ago (2017-02-22 15:33:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2693193003/60001
3 years, 10 months ago (2017-02-22 15:34:35 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 16:45:31 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/cece2b21dec5a8f8695a0bf7743a...

Powered by Google App Engine
This is Rietveld 408576698