Allow inline install for user initiated fullscreen mode.

chrome/browser/extensions/webstore_inline_installer_browsertest.cc

Index: chrome/browser/extensions/webstore_inline_installer_browsertest.cc
diff --git a/chrome/browser/extensions/webstore_inline_installer_browsertest.cc b/chrome/browser/extensions/webstore_inline_installer_browsertest.cc
index 35d5edc9ad59df5294548ebf227a1646a024bf0b..0b75718a9a71ed5886383b62e4611a8f6813c90c 100644
--- a/chrome/browser/extensions/webstore_inline_installer_browsertest.cc
+++ b/chrome/browser/extensions/webstore_inline_installer_browsertest.cc
@@ -263,12 +263,13 @@ IN_PROC_BROWSER_TEST_F(WebstoreInlineInstallerTest,
   RunTest(popup_contents, "runTest");
 }
 
-// Prevent inline install while in browser fullscreen mode. Browser fullscreen
-// is initiated by the user using F11.
+// Allow inline install while in browser fullscreen mode. Browser fullscreen
+// is initiated by the user using F11 (windows), ctrl+cmd+F (mac) or the green
+// maximize window button on mac. This will be allowed since it cannot be
+// initiated by an API and because of the nuance with mac windows.
 IN_PROC_BROWSER_TEST_F(WebstoreInlineInstallerTest,
-                       BlockInlineInstallFromFullscreenForBrowser) {
-  const GURL install_url =
-      GenerateTestServerUrl(kAppDomain, "install_from_fullscreen.html");
+                       AllowInlineInstallFromFullscreenForBrowser) {
+  const GURL install_url = GenerateTestServerUrl(kAppDomain, "install.html");
   ui_test_utils::NavigateToURL(browser(), install_url);
   AutoAcceptInstall();
 
@@ -279,10 +280,10 @@ IN_PROC_BROWSER_TEST_F(WebstoreInlineInstallerTest,
 
   RunTest("runTest");
 
-  // Ensure extension is not installed.
+  // Ensure extension is installed.
   ExtensionRegistry* registry = ExtensionRegistry::Get(profile());
-  EXPECT_FALSE(registry->GenerateInstalledExtensionsSet()->Contains(
-      "bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb"));
+  EXPECT_TRUE(registry->GenerateInstalledExtensionsSet()->Contains(
+      "ecglahbcnmdpdciemllbhojghbkagdje"));

[Devlin, 2017/02/15 15:48:06]

huh.  b.repeat(32) wasn't the id?  Does that mean that these tests weren't
actually testing anything before? (Because the registry would never contain that
id?)  Should have caught that in the original review; my bad.

Looks like we have this string const'd as kTestExtensionId on line 43, prefer
that.

[Devlin, 2017/02/15 17:01:12]

nvm, all cleared up (but still please use kTestExtensionId here)

[Ackerman, 2017/02/15 17:28:39]

Done.

 }
 
 // Prevent inline install while in tab fullscreen mode. Tab fullscreen is