Allow inline install for user initiated fullscreen mode.

chrome/browser/extensions/webstore_inline_installer_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/webstore_inline_installer.h"
 
 #include "base/json/json_reader.h"
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 245 matching lines @@
   ui_test_utils::NavigateToURL(browser(), install_url);
   // The test page opens a popup which is a new |browser| window.
   Browser* popup_browser =
       chrome::FindLastActiveWithProfile(browser()->profile());
   WebContents* popup_contents =
       popup_browser->tab_strip_model()->GetActiveWebContents();
   EXPECT_EQ(base::ASCIIToUTF16("POPUP"), popup_contents->GetTitle());
   RunTest(popup_contents, "runTest");
 }
 
-// Prevent inline install while in browser fullscreen mode. Browser fullscreen
-// is initiated by the user using F11.
+// Allow inline install while in browser fullscreen mode. Browser fullscreen
+// is initiated by the user using F11 (windows), ctrl+cmd+F (mac) or the green
+// maximize window button on mac. This will be allowed since it cannot be
+// initiated by an API and because of the nuance with mac windows.
 IN_PROC_BROWSER_TEST_F(WebstoreInlineInstallerTest,
-                       BlockInlineInstallFromFullscreenForBrowser) {
-  const GURL install_url =
-      GenerateTestServerUrl(kAppDomain, "install_from_fullscreen.html");
+                       AllowInlineInstallFromFullscreenForBrowser) {
+  const GURL install_url = GenerateTestServerUrl(kAppDomain, "install.html");
   ui_test_utils::NavigateToURL(browser(), install_url);
   AutoAcceptInstall();
 
   // Enter browser fullscreen mode.
   FullscreenController* controller =
       browser()->exclusive_access_manager()->fullscreen_controller();
   controller->ToggleBrowserFullscreenMode();
 
   RunTest("runTest");
 
-  // Ensure extension is not installed.
+  // Ensure extension is installed.
   ExtensionRegistry* registry = ExtensionRegistry::Get(profile());
-  EXPECT_FALSE(registry->GenerateInstalledExtensionsSet()->Contains(
-      "bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb"));
+  EXPECT_TRUE(registry->GenerateInstalledExtensionsSet()->Contains(
+      "ecglahbcnmdpdciemllbhojghbkagdje"));

[Devlin, 2017/02/15 15:48:06]

huh.  b.repeat(32) wasn't the id?  Does that mean that these tests weren't
actually testing anything before? (Because the registry would never contain that
id?)  Should have caught that in the original review; my bad.

Looks like we have this string const'd as kTestExtensionId on line 43, prefer
that.

[Devlin, 2017/02/15 17:01:12]

nvm, all cleared up (but still please use kTestExtensionId here)

[Ackerman, 2017/02/15 17:28:39]

Done.

 }
 
 // Prevent inline install while in tab fullscreen mode. Tab fullscreen is
 // initiated using the browser API.
 IN_PROC_BROWSER_TEST_F(WebstoreInlineInstallerTest,
                        BlockInlineInstallFromFullscreenForTab) {
   const GURL install_url =
       GenerateTestServerUrl(kAppDomain, "install_from_fullscreen.html");
   ui_test_utils::NavigateToURL(browser(), install_url);
   AutoAcceptInstall();
   WebContents* web_contents =
       browser()->tab_strip_model()->GetActiveWebContents();
   FullscreenController* controller =
       browser()->exclusive_access_manager()->fullscreen_controller();
 
   // Enter tab fullscreen mode.
   controller->EnterFullscreenModeForTab(web_contents, install_url);
 
   RunTest("runTest");
 
   // Ensure extension is not installed.
   ExtensionRegistry* registry = ExtensionRegistry::Get(profile());
   EXPECT_FALSE(registry->GenerateInstalledExtensionsSet()->Contains(
       "bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb"));

[Devlin, 2017/02/15 15:48:05]

In line with the above, seems like this should be kTestExtensionId instead of
bbbbb...

[Devlin, 2017/02/15 17:01:12]

ignore

[Ackerman, 2017/02/15 17:28:39]

Updated to use the test extension id in install_from_fullscreen.html and updated
here to use kTestExtensionId.

 }
 
 // Ensure that inline-installing a disabled extension simply re-enables it.
 IN_PROC_BROWSER_TEST_F(WebstoreInlineInstallerTest,
                        ReinstallDisabledExtension) {
   // Install an extension via inline install, and confirm it is successful.
   AutoAcceptInstall();
   ui_test_utils::NavigateToURL(
       browser(), GenerateTestServerUrl(kAppDomain, "install.html"));
   RunTest("runTest");
@@ skipping 162 matching lines @@
       WindowOpenDisposition::NEW_FOREGROUND_TAB,
       ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);
   DCHECK_NE(old_tab_index, browser()->tab_strip_model()->active_index());
   browser()->tab_strip_model()->CloseWebContentsAt(old_tab_index,
                                                    TabStripModel::CLOSE_NONE);
   WebstoreInstallerTest::RunTest("runTest");
   EXPECT_TRUE(registry->enabled_extensions().GetByID(kTestExtensionId));
 }
 
 }  // namespace extensions