Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: chrome/browser/extensions/webstore_inline_installer_browsertest.cc

Issue 2693183002: Allow inline install for user initiated fullscreen mode. (Closed)
Patch Set: Allow inline install for user initiated fullscreen mode. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/webstore_inline_installer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/webstore_inline_installer_browsertest.cc
diff --git a/chrome/browser/extensions/webstore_inline_installer_browsertest.cc b/chrome/browser/extensions/webstore_inline_installer_browsertest.cc
index 35d5edc9ad59df5294548ebf227a1646a024bf0b..bd7abff9ad79d553178f820116783b48d5959420 100644
--- a/chrome/browser/extensions/webstore_inline_installer_browsertest.cc
+++ b/chrome/browser/extensions/webstore_inline_installer_browsertest.cc
@@ -263,28 +263,6 @@ IN_PROC_BROWSER_TEST_F(WebstoreInlineInstallerTest,
RunTest(popup_contents, "runTest");
}
-// Prevent inline install while in browser fullscreen mode. Browser fullscreen
-// is initiated by the user using F11.
-IN_PROC_BROWSER_TEST_F(WebstoreInlineInstallerTest,
- BlockInlineInstallFromFullscreenForBrowser) {
Devlin 2017/02/14 23:19:52 Instead of deleting this, let's make it a test for
- const GURL install_url =
- GenerateTestServerUrl(kAppDomain, "install_from_fullscreen.html");
- ui_test_utils::NavigateToURL(browser(), install_url);
- AutoAcceptInstall();
-
- // Enter browser fullscreen mode.
- FullscreenController* controller =
- browser()->exclusive_access_manager()->fullscreen_controller();
- controller->ToggleBrowserFullscreenMode();
-
- RunTest("runTest");
-
- // Ensure extension is not installed.
- ExtensionRegistry* registry = ExtensionRegistry::Get(profile());
- EXPECT_FALSE(registry->GenerateInstalledExtensionsSet()->Contains(
- "bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb"));
-}
-
// Prevent inline install while in tab fullscreen mode. Tab fullscreen is
// initiated using the browser API.
IN_PROC_BROWSER_TEST_F(WebstoreInlineInstallerTest,
« no previous file with comments | « chrome/browser/extensions/webstore_inline_installer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698