Allow inline install for user initiated fullscreen mode.

chrome/browser/extensions/webstore_inline_installer_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/webstore_inline_installer.h"
 
 #include "base/json/json_reader.h"
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 245 matching lines @@
   ui_test_utils::NavigateToURL(browser(), install_url);
   // The test page opens a popup which is a new |browser| window.
   Browser* popup_browser =
       chrome::FindLastActiveWithProfile(browser()->profile());
   WebContents* popup_contents =
       popup_browser->tab_strip_model()->GetActiveWebContents();
   EXPECT_EQ(base::ASCIIToUTF16("POPUP"), popup_contents->GetTitle());
   RunTest(popup_contents, "runTest");
 }
 
-// Prevent inline install while in browser fullscreen mode. Browser fullscreen
-// is initiated by the user using F11.
-IN_PROC_BROWSER_TEST_F(WebstoreInlineInstallerTest,
-                       BlockInlineInstallFromFullscreenForBrowser) {

[Devlin, 2017/02/14 23:19:52]

Instead of deleting this, let's make it a test for
AllowInlineInstallationFromFullscreenForBrowser (and add a comment for why we
allow it).

-  const GURL install_url =
-      GenerateTestServerUrl(kAppDomain, "install_from_fullscreen.html");
-  ui_test_utils::NavigateToURL(browser(), install_url);
-  AutoAcceptInstall();
-
-  // Enter browser fullscreen mode.
-  FullscreenController* controller =
-      browser()->exclusive_access_manager()->fullscreen_controller();
-  controller->ToggleBrowserFullscreenMode();
-
-  RunTest("runTest");
-
-  // Ensure extension is not installed.
-  ExtensionRegistry* registry = ExtensionRegistry::Get(profile());
-  EXPECT_FALSE(registry->GenerateInstalledExtensionsSet()->Contains(
-      "bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb"));
-}
-
 // Prevent inline install while in tab fullscreen mode. Tab fullscreen is
 // initiated using the browser API.
 IN_PROC_BROWSER_TEST_F(WebstoreInlineInstallerTest,
                        BlockInlineInstallFromFullscreenForTab) {
   const GURL install_url =
       GenerateTestServerUrl(kAppDomain, "install_from_fullscreen.html");
   ui_test_utils::NavigateToURL(browser(), install_url);
   AutoAcceptInstall();
   WebContents* web_contents =
       browser()->tab_strip_model()->GetActiveWebContents();
@@ skipping 184 matching lines @@
       WindowOpenDisposition::NEW_FOREGROUND_TAB,
       ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);
   DCHECK_NE(old_tab_index, browser()->tab_strip_model()->active_index());
   browser()->tab_strip_model()->CloseWebContentsAt(old_tab_index,
                                                    TabStripModel::CLOSE_NONE);
   WebstoreInstallerTest::RunTest("runTest");
   EXPECT_TRUE(registry->enabled_extensions().GetByID(kTestExtensionId));
 }
 
 }  // namespace extensions