Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issue 2693143002: Cleanup in NTP single-iframe (Closed)

Created:
3 years, 10 months ago by Marc Treib
Modified:
3 years, 10 months ago
Reviewers:
sfiera
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, arv+watch_chromium.org, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup in NTP single-iframe - Add a few comments - Rename some functions for (IMO) better clarity - Remove "file://" as an allowed scheme: support for it has been removed a long time ago; see https://codereview.chromium.org/1924773002 BUG=687972 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2693143002 Cr-Commit-Position: refs/heads/master@{#450346} Committed: https://chromium.googlesource.com/chromium/src/+/cfa2dfc45824fd0b7c912ee050e441807b1d3d09

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -14 lines) Patch
M chrome/browser/resources/local_ntp/most_visited_single.js View 4 chunks +23 lines, -14 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Marc Treib
PTAL!
3 years, 10 months ago (2017-02-14 13:35:59 UTC) #7
sfiera
LGTM
3 years, 10 months ago (2017-02-14 13:58:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2693143002/1
3 years, 10 months ago (2017-02-14 14:05:47 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 14:11:17 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cfa2dfc45824fd0b7c912ee050e4...

Powered by Google App Engine
This is Rietveld 408576698