Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Unified Diff: content/public/renderer/webrtc_udp_transport.h

Issue 26931002: Define Cast Content API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: revised API and comments Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/renderer/webrtc_udp_transport.h
diff --git a/content/public/renderer/webrtc_udp_transport.h b/content/public/renderer/webrtc_udp_transport.h
new file mode 100644
index 0000000000000000000000000000000000000000..8daa958b543d3ca5d5e2afcdb3135ed90c5381be
--- /dev/null
+++ b/content/public/renderer/webrtc_udp_transport.h
@@ -0,0 +1,38 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_PUBLIC_RENDERER_MEDIA_WEBRTC_UDP_TRANSPORT_H_
jam 2013/10/11 16:47:14 nit: get rid of _MEDIA_
Alpha Left Google 2013/10/11 20:24:21 Done.
+#define CONTENT_PUBLIC_RENDERER_MEDIA_WEBRTC_UDP_TRANSPORT_H_
+
+#include <string>
jam 2013/10/11 16:47:14 ditto
Alpha Left Google 2013/10/11 20:24:21 Done.
+#include <vector>
jam 2013/10/11 16:47:14 nit: not needed
Alpha Left Google 2013/10/11 20:24:21 Done.
+
+#include "base/callback.h"
jam 2013/10/11 16:47:14 ditto
Alpha Left Google 2013/10/11 20:24:21 Done.
+#include "content/common/content_export.h"
+#include "net/base/address_family.h"
jam 2013/10/11 16:47:14 ditto
Alpha Left Google 2013/10/11 20:24:21 Done.
+#include "net/base/ip_endpoint.h"
+
+namespace content {
+
+// An interface that represents an end point to which communication is
+// done by UDP. The interface does not allow direct access to a UDP socket
+// but represents a transport mechanism.
+class CONTENT_EXPORT WebRtcUdpTransport {
jam 2013/10/11 16:47:14 nit: export not needed
Alpha Left Google 2013/10/11 20:24:21 Done.
+ public:
+ // Begin the transport by specifying the remote IP address.
+ // The transport will use UDP.
+ virtual void start(net::IPEndPoint remote_address) = 0;
jam 2013/10/11 16:47:14 nit: google style guide means Start and Stop
Alpha Left Google 2013/10/11 20:24:21 Sorry! Been doing Blink lately and mixed up the st
+
+ // Terminate the communication with the end point.
+ virtual void stop() = 0;
+
+ protected:
+ virtual ~WebRtcUdpTransport() {}
+};
+
+CONTENT_EXPORT WebRtcUdpTransport* CreateWebRtcUdpTransport();
jam 2013/10/11 16:47:14 nit: convention is we put this static method insid
Alpha Left Google 2013/10/11 20:24:21 Done.
+
+} // namespace content
+
+#endif // CONTENT_PUBLIC_RENDERER_MEDIA_WEBRTC_UDP_TRANSPORT_H_

Powered by Google App Engine
This is Rietveld 408576698