Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Side by Side Diff: content/public/renderer/webrtc_udp_transport.h

Issue 26931002: Define Cast Content API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: revised API and comments Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CONTENT_PUBLIC_RENDERER_MEDIA_WEBRTC_UDP_TRANSPORT_H_
jam 2013/10/11 16:47:14 nit: get rid of _MEDIA_
Alpha Left Google 2013/10/11 20:24:21 Done.
6 #define CONTENT_PUBLIC_RENDERER_MEDIA_WEBRTC_UDP_TRANSPORT_H_
7
8 #include <string>
jam 2013/10/11 16:47:14 ditto
Alpha Left Google 2013/10/11 20:24:21 Done.
9 #include <vector>
jam 2013/10/11 16:47:14 nit: not needed
Alpha Left Google 2013/10/11 20:24:21 Done.
10
11 #include "base/callback.h"
jam 2013/10/11 16:47:14 ditto
Alpha Left Google 2013/10/11 20:24:21 Done.
12 #include "content/common/content_export.h"
13 #include "net/base/address_family.h"
jam 2013/10/11 16:47:14 ditto
Alpha Left Google 2013/10/11 20:24:21 Done.
14 #include "net/base/ip_endpoint.h"
15
16 namespace content {
17
18 // An interface that represents an end point to which communication is
19 // done by UDP. The interface does not allow direct access to a UDP socket
20 // but represents a transport mechanism.
21 class CONTENT_EXPORT WebRtcUdpTransport {
jam 2013/10/11 16:47:14 nit: export not needed
Alpha Left Google 2013/10/11 20:24:21 Done.
22 public:
23 // Begin the transport by specifying the remote IP address.
24 // The transport will use UDP.
25 virtual void start(net::IPEndPoint remote_address) = 0;
jam 2013/10/11 16:47:14 nit: google style guide means Start and Stop
Alpha Left Google 2013/10/11 20:24:21 Sorry! Been doing Blink lately and mixed up the st
26
27 // Terminate the communication with the end point.
28 virtual void stop() = 0;
29
30 protected:
31 virtual ~WebRtcUdpTransport() {}
32 };
33
34 CONTENT_EXPORT WebRtcUdpTransport* CreateWebRtcUdpTransport();
jam 2013/10/11 16:47:14 nit: convention is we put this static method insid
Alpha Left Google 2013/10/11 20:24:21 Done.
35
36 } // namespace content
37
38 #endif // CONTENT_PUBLIC_RENDERER_MEDIA_WEBRTC_UDP_TRANSPORT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698