Unload old Cast extensions after initializing ToolbarActionsModel

Unload old Cast extensions after initializing ToolbarActionsModel

With the removal of ComponentMigrationHelper, we removed the mechanism for
unloading the old Cast and Cast Beta extensions, which have been replaced by
Media Router and are no longer functional. This CL adds back unloading of those
extensions so that users would not see the old extensions.

BUG=691575
Review-Url: https://codereview.chromium.org/2693063003
Cr-Commit-Position: refs/heads/master@{#450761}
Committed: https://chromium.googlesource.com/chromium/src/+/6ac78638dbd719015453216fb4c9fa8185bc885f

[takumif, 2017-02-14 18:00:23]

Description was changed from

==========
Unload old Cast extensions after initializing ToolbarActionsModel

BUG=691575
==========

to

==========
Unload old Cast extensions after initializing ToolbarActionsModel

With the removal of ComponentMigrationHelper, we removed the mechanism for
unloading the old Cast and Cast Beta extensions, which have been replaced by
Media Router and are no longer functional. This CL adds back unloading of those
extensions so that users would not see the old extensions.

BUG=691575
==========

[takumif, 2017-02-14 18:00:38]

Description was changed from

==========
Unload old Cast extensions after initializing ToolbarActionsModel

With the removal of ComponentMigrationHelper, we removed the mechanism for
unloading the old Cast and Cast Beta extensions, which have been replaced by
Media Router and are no longer functional. This CL adds back unloading of those
extensions so that users would not see the old extensions.

BUG=691575
==========

to

==========
Unload old Cast extensions after initializing ToolbarActionsModel

With the removal of ComponentMigrationHelper, we removed the mechanism for
unloading the old Cast and Cast Beta extensions, which have been replaced by
Media Router and are no longer functional. This CL adds back unloading of those
extensions so that users would not see the old extensions.

BUG=691575
==========

[takumif, 2017-02-14 18:03:34]

takumif@chromium.org changed reviewers:
+ mfoltz@chromium.org, rdevlin.cronin@chromium.org

[takumif, 2017-02-14 18:03:34]

Please take a look, thank you!

[mark a. foltz, 2017-02-14 23:16:09]

LGTM

Is there a path to uninstalling these extensions so we don't have to keep this
code around forever?

https://codereview.chromium.org/2693063003/diff/1/chrome/browser/ui/toolbar/t...
File chrome/browser/ui/toolbar/toolbar_actions_model.cc (right):

https://codereview.chromium.org/2693063003/diff/1/chrome/browser/ui/toolbar/t...
chrome/browser/ui/toolbar/toolbar_actions_model.cc:272: if (use_redesign_) {
Is it still possible to turn the extension action redesign off?  I suppose so if
this flag is still present.

[Devlin, 2017-02-14 23:18:49]

> Is there a path to uninstalling these extensions so we don't have to keep this
> code around forever?
+1 - can we add a TODO?

https://codereview.chromium.org/2693063003/diff/1/chrome/browser/ui/toolbar/t...
File chrome/browser/ui/toolbar/toolbar_actions_model.cc (right):

https://codereview.chromium.org/2693063003/diff/1/chrome/browser/ui/toolbar/t...
chrome/browser/ui/toolbar/toolbar_actions_model.cc:272: if (use_redesign_) {
On 2017/02/14 23:16:09, mark a. foltz wrote:
> Is it still possible to turn the extension action redesign off?  I suppose so
if
> this flag is still present.

I'm slowly working on removing them all; I'll get to this one soon. :)

[takumif, 2017-02-14 23:47:05]

Patchset #2 (id:20001) has been deleted

[takumif, 2017-02-14 23:47:45]

On 2017/02/14 23:18:49, Devlin wrote:
> > Is there a path to uninstalling these extensions so we don't have to keep
this
> > code around forever?
> +1 - can we add a TODO?
Done. To uninstall, I think we can simply call
ExtensionService::UninstallExtensionHelper() from here, but I haven't tried it
yet.

[Devlin, 2017-02-14 23:58:43]

lgtm

https://codereview.chromium.org/2693063003/diff/40001/chrome/browser/ui/toolb...
File chrome/browser/ui/toolbar/component_toolbar_actions_factory.h (right):

https://codereview.chromium.org/2693063003/diff/40001/chrome/browser/ui/toolb...
chrome/browser/ui/toolbar/component_toolbar_actions_factory.h:51: virtual void
UnloadMigratedExtensions(
Does this need to be virtual?

[takumif, 2017-02-15 03:39:12]

The CQ bit was checked by takumif@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 03:39:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 05:26:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 05:26:23]

Dry run: This issue passed the CQ dry run.

[takumif, 2017-02-15 18:13:47]

Thanks for reviewing!
Regarding the uninstallation, Stephen agreed that we can go ahead and add it.

https://codereview.chromium.org/2693063003/diff/40001/chrome/browser/ui/toolb...
File chrome/browser/ui/toolbar/component_toolbar_actions_factory.h (right):

https://codereview.chromium.org/2693063003/diff/40001/chrome/browser/ui/toolb...
chrome/browser/ui/toolbar/component_toolbar_actions_factory.h:51: virtual void
UnloadMigratedExtensions(
On 2017/02/14 23:58:43, Devlin wrote:
> Does this need to be virtual?

No. Removed.

[takumif, 2017-02-15 18:13:58]

The CQ bit was checked by takumif@chromium.org

[takumif, 2017-02-15 18:13:59]

The patchset sent to the CQ was uploaded after l-g-t-m from mfoltz@chromium.org,
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/2693063003/#ps60001
(title: "Remove virtual, rebase")

[commit-bot: I haz the power, 2017-02-15 18:14:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 19:16:27]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487182438966710,
"parent_rev": "223163006109b9b54a8421f4ca8139403ad63e0d", "commit_rev":
"6ac78638dbd719015453216fb4c9fa8185bc885f"}

[commit-bot: I haz the power, 2017-02-15 19:17:04]

Description was changed from

==========
Unload old Cast extensions after initializing ToolbarActionsModel

With the removal of ComponentMigrationHelper, we removed the mechanism for
unloading the old Cast and Cast Beta extensions, which have been replaced by
Media Router and are no longer functional. This CL adds back unloading of those
extensions so that users would not see the old extensions.

BUG=691575
==========

to

==========
Unload old Cast extensions after initializing ToolbarActionsModel

With the removal of ComponentMigrationHelper, we removed the mechanism for
unloading the old Cast and Cast Beta extensions, which have been replaced by
Media Router and are no longer functional. This CL adds back unloading of those
extensions so that users would not see the old extensions.

BUG=691575

Review-Url: https://codereview.chromium.org/2693063003
Cr-Commit-Position: refs/heads/master@{#450761}
Committed:
https://chromium.googlesource.com/chromium/src/+/6ac78638dbd719015453216fb4c9...
==========

[commit-bot: I haz the power, 2017-02-15 19:17:05]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/6ac78638dbd719015453216fb4c9...