Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 2693063002: Renamed /services/memory_infrastructure to /services/resource_coordinator (Closed)

Created:
3 years, 10 months ago by oystein (OOO til 10th of July)
Modified:
3 years, 10 months ago
CC:
Aaron Boodman, abarth-chromium, chrisha, chromium-reviews, darin (slow to review), Primiano Tucci (use gerrit), qsr+mojo_chromium.org, tracing+reviews_chromium.org, viettrungluu+watch_chromium.org, vmpstr+watch_chromium.org, wfh+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Renamed /services/memory_infrastructure to /services/resource_coordinator The memory_infra bindings are now in a subfolder of this service, in preparation for more functionality being added. Also changed the OWNERS file from pointing to /base/trace_event/OWNERS to a reasonable set of people involved who are also owners elsewhere. R=chiniforooshan@chromium.org,jam@chromium.org BUG=691886 Review-Url: https://codereview.chromium.org/2693063002 Cr-Commit-Position: refs/heads/master@{#450482} Committed: https://chromium.googlesource.com/chromium/src/+/f4729b0eccefc8bd9f46d4e36144b9a53cd02e33

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 2

Patch Set 3 : Review fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -940 lines) Patch
M base/trace_event/memory_dump_request_args.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/tools/bindings/chromium_bindings_configuration.gni View 1 chunk +1 line, -1 line 0 comments Download
M services/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
D services/memory_instrumentation/BUILD.gn View 1 chunk +0 lines, -31 lines 0 comments Download
D services/memory_instrumentation/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D services/memory_instrumentation/coordinator_impl.h View 1 chunk +0 lines, -87 lines 0 comments Download
D services/memory_instrumentation/coordinator_impl.cc View 1 chunk +0 lines, -186 lines 0 comments Download
D services/memory_instrumentation/coordinator_impl_unittest.cc View 1 chunk +0 lines, -146 lines 0 comments Download
D services/memory_instrumentation/public/cpp/BUILD.gn View 1 chunk +0 lines, -34 lines 0 comments Download
D services/memory_instrumentation/public/cpp/coordinator.h View 1 chunk +0 lines, -20 lines 0 comments Download
D services/memory_instrumentation/public/cpp/memory_dump_manager_delegate_impl.h View 1 chunk +0 lines, -51 lines 0 comments Download
D services/memory_instrumentation/public/cpp/memory_dump_manager_delegate_impl.cc View 1 chunk +0 lines, -48 lines 0 comments Download
D services/memory_instrumentation/public/cpp/memory_instrumentation.typemap View 1 chunk +0 lines, -16 lines 0 comments Download
D services/memory_instrumentation/public/cpp/memory_instrumentation_traits.h View 1 chunk +0 lines, -52 lines 0 comments Download
D services/memory_instrumentation/public/cpp/memory_instrumentation_traits.cc View 1 chunk +0 lines, -107 lines 0 comments Download
D services/memory_instrumentation/public/cpp/typemaps.gni View 1 chunk +0 lines, -5 lines 0 comments Download
D services/memory_instrumentation/public/interfaces/BUILD.gn View 1 chunk +0 lines, -11 lines 0 comments Download
D services/memory_instrumentation/public/interfaces/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D services/memory_instrumentation/public/interfaces/memory_instrumentation.mojom View 1 chunk +0 lines, -39 lines 0 comments Download
A + services/resource_coordinator/BUILD.gn View 2 chunks +5 lines, -5 lines 0 comments Download
A services/resource_coordinator/OWNERS View 1 chunk +4 lines, -0 lines 0 comments Download
A + services/resource_coordinator/memory/coordinator/coordinator_impl.h View 5 chunks +9 lines, -9 lines 0 comments Download
A + services/resource_coordinator/memory/coordinator/coordinator_impl.cc View 7 chunks +9 lines, -15 lines 0 comments Download
A + services/resource_coordinator/memory/coordinator/coordinator_impl_unittest.cc View 8 chunks +18 lines, -26 lines 0 comments Download
A + services/resource_coordinator/public/cpp/BUILD.gn View 1 2 2 chunks +7 lines, -7 lines 0 comments Download
A services/resource_coordinator/public/cpp/memory/OWNERS View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
A + services/resource_coordinator/public/cpp/memory/coordinator.h View 1 chunk +1 line, -1 line 0 comments Download
A + services/resource_coordinator/public/cpp/memory/memory_dump_manager_delegate_impl.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + services/resource_coordinator/public/cpp/memory/memory_dump_manager_delegate_impl.cc View 2 chunks +5 lines, -4 lines 0 comments Download
A + services/resource_coordinator/public/cpp/memory/memory_instrumentation.typemap View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A + services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.h View 1 2 4 chunks +7 lines, -7 lines 0 comments Download
A + services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.cc View 1 2 5 chunks +20 lines, -20 lines 0 comments Download
A + services/resource_coordinator/public/cpp/typemaps.gni View 1 chunk +1 line, -1 line 0 comments Download
A + services/resource_coordinator/public/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + services/resource_coordinator/public/interfaces/OWNERS View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/resource_coordinator/public/interfaces/memory/OWNERS View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/resource_coordinator/public/interfaces/memory/memory_instrumentation.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 38 (24 generated)
oystein (OOO til 10th of July)
ptal! chiniforooshan: I rebased your WIP CL for the continued work in https://codereview.chromium.org/2690143004 so you ...
3 years, 10 months ago (2017-02-14 04:00:07 UTC) #2
Primiano Tucci (use gerrit)
I am a bit backlogged for doing an actual review, but the plan here sgtm. ...
3 years, 10 months ago (2017-02-14 12:33:13 UTC) #12
haraken
LGTM 2
3 years, 10 months ago (2017-02-14 12:52:17 UTC) #13
chiniforooshan
lgtm
3 years, 10 months ago (2017-02-14 16:08:27 UTC) #14
Ken Rockot(use gerrit already)
lgtm
3 years, 10 months ago (2017-02-14 16:46:16 UTC) #16
oystein (OOO til 10th of July)
On 2017/02/14 at 16:46:16, rockot wrote: > lgtm Thanks! +dcheng for the .mojom move
3 years, 10 months ago (2017-02-14 17:38:39 UTC) #18
Will Harris
rs security lgtm if you need one in a hurry.
3 years, 10 months ago (2017-02-14 18:10:09 UTC) #19
oystein (OOO til 10th of July)
On 2017/02/14 at 18:10:09, wfh wrote: > rs security lgtm if you need one in ...
3 years, 10 months ago (2017-02-14 18:57:51 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2693063002/20001
3 years, 10 months ago (2017-02-14 18:58:31 UTC) #25
dcheng
LGTM with a nit. https://codereview.chromium.org/2693063002/diff/20001/services/resource_coordinator/public/cpp/memory/memory_instrumentation_traits.cc File services/resource_coordinator/public/cpp/memory/memory_instrumentation_traits.cc (right): https://codereview.chromium.org/2693063002/diff/20001/services/resource_coordinator/public/cpp/memory/memory_instrumentation_traits.cc#newcode1 services/resource_coordinator/public/cpp/memory/memory_instrumentation_traits.cc:1: // Copyright 2017 The Chromium ...
3 years, 10 months ago (2017-02-14 19:05:54 UTC) #26
dcheng
https://codereview.chromium.org/2693063002/diff/20001/services/resource_coordinator/public/cpp/memory/memory_instrumentation_traits.cc File services/resource_coordinator/public/cpp/memory/memory_instrumentation_traits.cc (right): https://codereview.chromium.org/2693063002/diff/20001/services/resource_coordinator/public/cpp/memory/memory_instrumentation_traits.cc#newcode1 services/resource_coordinator/public/cpp/memory/memory_instrumentation_traits.cc:1: // Copyright 2017 The Chromium Authors. All rights reserved. ...
3 years, 10 months ago (2017-02-14 19:06:29 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/364108)
3 years, 10 months ago (2017-02-14 19:09:36 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2693063002/40001
3 years, 10 months ago (2017-02-14 21:23:28 UTC) #35
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 21:36:27 UTC) #38
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f4729b0eccefc8bd9f46d4e36144...

Powered by Google App Engine
This is Rietveld 408576698