Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions.
The expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects at most 10 tests.

BUG=639732
Review-Url: https://codereview.chromium.org/2693043012
Cr-Commit-Position: refs/heads/master@{#451067}
Committed: https://chromium.googlesource.com/chromium/src/+/6efdc2adcb4b01195b731abae41bb8b1bbf1f9b9

[zakerinasab, 2017-02-15 18:46:51]

Description was changed from

==========
Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions.
The expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects at most 10 tests.

BUG=639732
==========

to

==========
Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions.
The expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects at most 10 tests.

BUG=639732
==========

[zakerinasab, 2017-02-15 18:46:52]

zakerinasab@chromium.org changed reviewers:
+ junov@chromium.org

[Justin Novosad, 2017-02-15 20:02:28]

https://codereview.chromium.org/2693043012/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/canvas/canvas-toDataURL-webp.html
(right):

https://codereview.chromium.org/2693043012/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-toDataURL-webp.html:8:
window.testRunner.dumpAsTextWithPixelResults();
You missed this test.

https://codereview.chromium.org/2693043012/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-toDataURL-webp.html:22: if
(!dataURL.match(/^data:image\/webp[;, ]/))
why?

https://codereview.chromium.org/2693043012/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/canvas/canvas-transparency-and-composite.html
(right):

https://codereview.chromium.org/2693043012/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-transparency-and-composite.html:22:
}, "Series of tests to ensure correct behaviour of composite on a fully
transparent color.");
This does not look like a "series"

https://codereview.chromium.org/2693043012/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/canvas/canvas-webkitLineDash.html
(right):

https://codereview.chromium.org/2693043012/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-webkitLineDash.html:14:
assert_equals(ctx.webkitLineDashOffset, undefined);
webkit-prefixed stuff was removed from the IDL a while ago. You should just
delete this test.

[zakerinasab, 2017-02-16 17:32:07]

Comments addressed.

https://codereview.chromium.org/2693043012/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/canvas/canvas-toDataURL-webp.html
(right):

https://codereview.chromium.org/2693043012/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-toDataURL-webp.html:8:
window.testRunner.dumpAsTextWithPixelResults();
On 2017/02/15 20:02:28, Justin Novosad wrote:
> You missed this test.

This is not a js-test.js based layout test. We have a bunch of these tests that
rely on the visual properties of the output (like this one) and do not check the
pixel values. For now I ignore these tests, but I think we need to address these
later. I removed this one from the CL for now.

https://codereview.chromium.org/2693043012/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-toDataURL-webp.html:22: if
(!dataURL.match(/^data:image\/webp[;, ]/))
On 2017/02/15 20:02:28, Justin Novosad wrote:
> why?

Because this is an image/webp data url?

https://codereview.chromium.org/2693043012/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/canvas/canvas-transparency-and-composite.html
(right):

https://codereview.chromium.org/2693043012/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-transparency-and-composite.html:22:
}, "Series of tests to ensure correct behaviour of composite on a fully
transparent color.");
On 2017/02/15 20:02:28, Justin Novosad wrote:
> This does not look like a "series"

It is slipped from the old test. Corrected.

https://codereview.chromium.org/2693043012/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/canvas/canvas-webkitLineDash.html
(right):

https://codereview.chromium.org/2693043012/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-webkitLineDash.html:14:
assert_equals(ctx.webkitLineDashOffset, undefined);
On 2017/02/15 20:02:28, Justin Novosad wrote:
> webkit-prefixed stuff was removed from the IDL a while ago. You should just
> delete this test.

Done.

[Justin Novosad, 2017-02-16 18:01:05]

lgtm

[zakerinasab, 2017-02-16 18:01:27]

The CQ bit was checked by zakerinasab@chromium.org

[commit-bot: I haz the power, 2017-02-16 18:02:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 19:57:29]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487268087504340,
"parent_rev": "326a7fdb3a840dd926b4b4ff14ca7fe24d87ffc0", "commit_rev":
"6efdc2adcb4b01195b731abae41bb8b1bbf1f9b9"}

[commit-bot: I haz the power, 2017-02-16 19:58:03]

Description was changed from

==========
Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions.
The expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects at most 10 tests.

BUG=639732
==========

to

==========
Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions.
The expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects at most 10 tests.

BUG=639732

Review-Url: https://codereview.chromium.org/2693043012
Cr-Commit-Position: refs/heads/master@{#451067}
Committed:
https://chromium.googlesource.com/chromium/src/+/6efdc2adcb4b01195b731abae41b...
==========

[commit-bot: I haz the power, 2017-02-16 19:58:05]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6efdc2adcb4b01195b731abae41b...