Remove //cc/ipc:struct_traits

Remove //cc/ipc:struct_traits

Sometimes we need the struct traits of one interface to depend on another
interface. For example, it could be that Foo has a BarPtr and therefore
we need to include bar.mojom.h in the struct traits of Foo. However,
currently we group all the struct traits into a source_set called
struct_traits and :interfaces depends on :struct_traits (see the
dependencies in the typemaps). If foo_struct_traits needs to include
bar.mojom.h, this creates a dependency from :struct_traits to :interfaces
and we would have a cycle. This CL gets rid of :struct_traits and now
all struct traits are listed in the typemaps.

TBR=vmpstr@chromium.org

BUG=692138
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2693043007
Cr-Commit-Position: refs/heads/master@{#450541}
Committed: https://chromium.googlesource.com/chromium/src/+/30e53545ee2155ee423a8c18d7895da50ac24305

[Saman Sami, 2017-02-14 20:38:27]

Description was changed from

==========
Remove //cc/ipc:struct_traits

BUG=692138
==========

to

==========
Remove //cc/ipc:struct_traits

BUG=692138
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Saman Sami, 2017-02-14 21:35:47]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 21:36:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-02-14 21:37:51]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 21:38:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-02-14 21:39:15]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[Saman Sami, 2017-02-14 21:39:23]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 21:39:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-02-14 21:40:08]

Description was changed from

==========
Remove //cc/ipc:struct_traits

BUG=692138
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Remove //cc/ipc:struct_traits

BUG=692138
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Saman Sami, 2017-02-14 21:40:08]

samans@chromium.org changed reviewers:
+ fsamuel@chromium.org, tsepez@chromium.org

[Saman Sami, 2017-02-14 21:41:13]

tsepez@: Please review all files.

[Saman Sami, 2017-02-14 21:46:27]

Description was changed from

==========
Remove //cc/ipc:struct_traits

BUG=692138
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Remove //cc/ipc:struct_traits

Sometimes we need the struct traits of one interface to depend on another
interface. For example, it could be that Foo has a BarPtr and therefore
we need to include bar.mojom.h in the struct traits of Foo. However,
currently we group all the struct traits into a source_set called
struct_traits and :interfaces depends on :struct_traits (see the
dependencies in the typemaps). If foo_struct_traits needs to include
bar.mojom.h, this creates a dependency from :struct_traits to :interfaces
and we would have a cycle. This CL gets rid of :struct_traits and now
all struct traits are listed in the typemaps.

BUG=692138
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Tom Sepez, 2017-02-14 21:46:37]

RS LGTM on deleting code.

[commit-bot: I haz the power, 2017-02-14 21:54:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 21:54:52]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Saman Sami, 2017-02-14 22:02:47]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[Saman Sami, 2017-02-14 22:03:15]

The CQ bit was unchecked by samans@chromium.org

[Saman Sami, 2017-02-14 22:03:19]

The CQ bit was checked by samans@chromium.org

[Saman Sami, 2017-02-14 22:03:19]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2693043007/#ps160001
(title: "c")

[commit-bot: I haz the power, 2017-02-14 22:03:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-02-14 22:18:34]

samans@chromium.org changed reviewers:
+ vmpstr@chromium.org

[Saman Sami, 2017-02-14 22:18:35]

vmpstr@: Please review cc/ipc/BUILD.gn

[commit-bot: I haz the power, 2017-02-14 22:21:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 22:21:53]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Saman Sami, 2017-02-15 00:32:25]

Description was changed from

==========
Remove //cc/ipc:struct_traits

Sometimes we need the struct traits of one interface to depend on another
interface. For example, it could be that Foo has a BarPtr and therefore
we need to include bar.mojom.h in the struct traits of Foo. However,
currently we group all the struct traits into a source_set called
struct_traits and :interfaces depends on :struct_traits (see the
dependencies in the typemaps). If foo_struct_traits needs to include
bar.mojom.h, this creates a dependency from :struct_traits to :interfaces
and we would have a cycle. This CL gets rid of :struct_traits and now
all struct traits are listed in the typemaps.

BUG=692138
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Remove //cc/ipc:struct_traits

Sometimes we need the struct traits of one interface to depend on another
interface. For example, it could be that Foo has a BarPtr and therefore
we need to include bar.mojom.h in the struct traits of Foo. However,
currently we group all the struct traits into a source_set called
struct_traits and :interfaces depends on :struct_traits (see the
dependencies in the typemaps). If foo_struct_traits needs to include
bar.mojom.h, this creates a dependency from :struct_traits to :interfaces
and we would have a cycle. This CL gets rid of :struct_traits and now
all struct traits are listed in the typemaps.

TBR=vmpstr@chromium.org

BUG=692138
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Saman Sami, 2017-02-15 00:32:32]

The CQ bit was checked by samans@chromium.org

[commit-bot: I haz the power, 2017-02-15 00:34:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 01:24:37]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1487118752171380,
"parent_rev": "5c6e9df99e78b8666e7016aae94ac2503c9adce9", "commit_rev":
"30e53545ee2155ee423a8c18d7895da50ac24305"}

[commit-bot: I haz the power, 2017-02-15 01:25:37]

Description was changed from

==========
Remove //cc/ipc:struct_traits

Sometimes we need the struct traits of one interface to depend on another
interface. For example, it could be that Foo has a BarPtr and therefore
we need to include bar.mojom.h in the struct traits of Foo. However,
currently we group all the struct traits into a source_set called
struct_traits and :interfaces depends on :struct_traits (see the
dependencies in the typemaps). If foo_struct_traits needs to include
bar.mojom.h, this creates a dependency from :struct_traits to :interfaces
and we would have a cycle. This CL gets rid of :struct_traits and now
all struct traits are listed in the typemaps.

TBR=vmpstr@chromium.org

BUG=692138
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Remove //cc/ipc:struct_traits

Sometimes we need the struct traits of one interface to depend on another
interface. For example, it could be that Foo has a BarPtr and therefore
we need to include bar.mojom.h in the struct traits of Foo. However,
currently we group all the struct traits into a source_set called
struct_traits and :interfaces depends on :struct_traits (see the
dependencies in the typemaps). If foo_struct_traits needs to include
bar.mojom.h, this creates a dependency from :struct_traits to :interfaces
and we would have a cycle. This CL gets rid of :struct_traits and now
all struct traits are listed in the typemaps.

TBR=vmpstr@chromium.org

BUG=692138
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2693043007
Cr-Commit-Position: refs/heads/master@{#450541}
Committed:
https://chromium.googlesource.com/chromium/src/+/30e53545ee2155ee423a8c18d789...
==========

[commit-bot: I haz the power, 2017-02-15 01:25:40]

Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/30e53545ee2155ee423a8c18d789...