Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2693043005: Fix should() to throw with no argument (Closed)

Created:
3 years, 10 months ago by hongchan
Modified:
3 years, 10 months ago
Reviewers:
Raymond Toy
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix should() to throw with no argument should() needs to check if it is getting proper arguments. No argument MUST throw. BUG=691010 TEST= LayoutTests/webaudio/unit-tests/audit.html Review-Url: https://codereview.chromium.org/2693043005 Cr-Commit-Position: refs/heads/master@{#450443} Committed: https://chromium.googlesource.com/chromium/src/+/4588d6d0889bd6cfc9c50dd1af6b5d206a55d366

Patch Set 1 : Initial commit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/webaudio/resources/audit.js View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/unit-tests/audit.html View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-expected.txt View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
hongchan
PTAL.
3 years, 10 months ago (2017-02-14 18:43:41 UTC) #3
Raymond Toy
lgtm
3 years, 10 months ago (2017-02-14 19:01:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2693043005/20001
3 years, 10 months ago (2017-02-14 19:03:36 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 20:21:48 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4588d6d0889bd6cfc9c50dd1af6b...

Powered by Google App Engine
This is Rietveld 408576698