Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2693033002: [DevTools] Always issue resize on viewport in FilteredListWidget. (Closed)

Created:
3 years, 10 months ago by dgozman
Modified:
3 years, 10 months ago
Reviewers:
einbinder, lushnikov
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Always issue resize on viewport in FilteredListWidget. Due to recent changes in GlassPane and setFixedHeight, checking dialog element's height does not work anymore. BUG=689433 Review-Url: https://codereview.chromium.org/2693033002 Cr-Commit-Position: refs/heads/master@{#450479} Committed: https://chromium.googlesource.com/chromium/src/+/733d09b5b7c0edd6e59d10e9e9d7a7fd81ab3509

Patch Set 1 #

Patch Set 2 : contain #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js View 1 chunk +1 line, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
dgozman
Take a look please.
3 years, 10 months ago (2017-02-14 00:07:16 UTC) #2
einbinder
lgtm
3 years, 10 months ago (2017-02-14 00:22:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2693033002/1
3 years, 10 months ago (2017-02-14 00:27:03 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-02-14 00:27:05 UTC) #7
dgozman
Andrey, PTAL.
3 years, 10 months ago (2017-02-14 00:33:55 UTC) #9
lushnikov
lgtm
3 years, 10 months ago (2017-02-14 19:28:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2693033002/20001
3 years, 10 months ago (2017-02-14 19:30:20 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 21:24:47 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/733d09b5b7c0edd6e59d10e9e9d7...

Powered by Google App Engine
This is Rietveld 408576698