Index: chrome/browser/chromeos/arc/boot_phase_monitor/arc_boot_phase_monitor_bridge.h |
diff --git a/chrome/browser/chromeos/arc/boot_phase_monitor/arc_boot_phase_monitor_bridge.h b/chrome/browser/chromeos/arc/boot_phase_monitor/arc_boot_phase_monitor_bridge.h |
index 407f450bc13c9a52bc284a26da4e133cdf0048f9..0ee09a5554b38ceda38dd930ef6f1f62d1324f2c 100644 |
--- a/chrome/browser/chromeos/arc/boot_phase_monitor/arc_boot_phase_monitor_bridge.h |
+++ b/chrome/browser/chromeos/arc/boot_phase_monitor/arc_boot_phase_monitor_bridge.h |
@@ -8,10 +8,13 @@ |
#include <memory> |
#include "base/macros.h" |
+#include "base/memory/weak_ptr.h" |
Luis Héctor Chávez
2017/02/15 19:32:32
nit: remove since it will be unused.
xzhou
2017/02/16 18:34:50
Done.
|
#include "base/threading/thread_checker.h" |
+#include "chrome/browser/profiles/profile.h" |
Luis Héctor Chávez
2017/02/15 19:32:32
nit: move to the .cc file and fwd-declare it here.
xzhou
2017/02/16 18:34:50
Done.
xzhou
2017/02/16 18:34:50
I changed to save AccountID per hidehiko's suggest
Yusuke Sato
2017/02/16 18:42:57
Your code seems fine as https://google.github.io/s
|
#include "components/arc/arc_service.h" |
#include "components/arc/common/boot_phase_monitor.mojom.h" |
#include "components/arc/instance_holder.h" |
+#include "components/signin/core/account_id/account_id.h" |
Luis Héctor Chávez
2017/02/15 19:32:32
nit: move it to the .cc since it's not used here.
xzhou
2017/02/16 18:34:50
Done.
|
#include "mojo/public/cpp/bindings/binding.h" |
namespace arc { |
@@ -25,7 +28,8 @@ class ArcBootPhaseMonitorBridge |
public InstanceHolder<mojom::BootPhaseMonitorInstance>::Observer, |
public mojom::BootPhaseMonitorHost { |
public: |
- explicit ArcBootPhaseMonitorBridge(ArcBridgeService* bridge_service); |
+ explicit ArcBootPhaseMonitorBridge(ArcBridgeService* bridge_service, |
Yusuke Sato
2017/02/15 18:31:37
remove explicit
xzhou
2017/02/16 18:34:50
Done.
|
+ Profile* profile); |
~ArcBootPhaseMonitorBridge() override; |
// InstanceHolder<mojom::BootPhaseMonitorInstance>::Observer |
@@ -34,12 +38,15 @@ class ArcBootPhaseMonitorBridge |
// mojom::BootPhaseMonitorHost |
void OnBootCompleted() override; |
+ void OnEmitArcBooted(bool success); |
private: |
+ Profile* profile; |
hidehiko
2017/02/15 18:48:09
s/profile/profile_/
Could you comment its lifetime
Luis Héctor Chávez
2017/02/15 19:02:11
Profile* const profile_;
(Chrome members have a t
xzhou
2017/02/16 18:34:50
Done.
xzhou
2017/02/16 18:34:50
Done.
xzhou
2017/02/16 18:34:50
Done.
xzhou
2017/02/16 18:34:50
Done.
|
mojo::Binding<mojom::BootPhaseMonitorHost> binding_; |
std::unique_ptr<ArcInstanceThrottle> throttle_; |
base::ThreadChecker thread_checker_; |
+ base::WeakPtrFactory<ArcBootPhaseMonitorBridge> weak_ptr_factory_; |
Luis Héctor Chávez
2017/02/15 19:02:11
nit: remove
xzhou
2017/02/16 18:34:50
Done.
|
DISALLOW_COPY_AND_ASSIGN(ArcBootPhaseMonitorBridge); |
}; |