arc: Add cryptohome_id to EmitArcBooted.

chrome/browser/chromeos/arc/boot_phase_monitor/arc_boot_phase_monitor_bridge.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_ARC_BOOT_PHASE_MONITOR_ARC_BOOT_PHASE_MONITOR_BRIDGE_H_
 #define CHROME_BROWSER_CHROMEOS_ARC_BOOT_PHASE_MONITOR_ARC_BOOT_PHASE_MONITOR_BRIDGE_H_
 
 #include <memory>
 
 #include "base/macros.h"
+#include "base/memory/weak_ptr.h"

[Luis Héctor Chávez, 2017/02/15 19:32:32]

nit: remove since it will be unused.

[xzhou, 2017/02/16 18:34:50]

Done.

 #include "base/threading/thread_checker.h"
+#include "chrome/browser/profiles/profile.h"

[Luis Héctor Chávez, 2017/02/15 19:32:32]

nit: move to the .cc file and fwd-declare it here.

[xzhou, 2017/02/16 18:34:50]

Done.

[xzhou, 2017/02/16 18:34:50]

I changed to save AccountID per hidehiko's suggestions. Should I forward declare
as well? I see
src/chromium/src/ui/arc/notification/arc_notification_manager.h:57 directly
included account_id.h so I am not sure if I should also use forward declare
here. Happy to change it.

[Yusuke Sato, 2017/02/16 18:42:57]

Your code seems fine as
https://google.github.io/styleguide/cppguide.html#Forward_Declarations says "Try
to
avoid forward declarations of entities defined in another project."

 #include "components/arc/arc_service.h"
 #include "components/arc/common/boot_phase_monitor.mojom.h"
 #include "components/arc/instance_holder.h"
+#include "components/signin/core/account_id/account_id.h"

[Luis Héctor Chávez, 2017/02/15 19:32:32]

nit: move it to the .cc since it's not used here.

[xzhou, 2017/02/16 18:34:50]

Done.

 #include "mojo/public/cpp/bindings/binding.h"
 
 namespace arc {
 
 class ArcBridgeService;
 class ArcInstanceThrottle;
 
 // Receives boot phase notifications from ARC.
 class ArcBootPhaseMonitorBridge
     : public ArcService,
       public InstanceHolder<mojom::BootPhaseMonitorInstance>::Observer,
       public mojom::BootPhaseMonitorHost {
  public:
-  explicit ArcBootPhaseMonitorBridge(ArcBridgeService* bridge_service);
+  explicit ArcBootPhaseMonitorBridge(ArcBridgeService* bridge_service,

[Yusuke Sato, 2017/02/15 18:31:37]

remove explicit

[xzhou, 2017/02/16 18:34:50]

Done.

+                                     Profile* profile);
   ~ArcBootPhaseMonitorBridge() override;
 
   // InstanceHolder<mojom::BootPhaseMonitorInstance>::Observer
   void OnInstanceReady() override;
   void OnInstanceClosed() override;
 
   // mojom::BootPhaseMonitorHost
   void OnBootCompleted() override;
+  void OnEmitArcBooted(bool success);
 
  private:
+  Profile* profile;

[hidehiko, 2017/02/15 18:48:09]

s/profile/profile_/
Could you comment its lifetime and ownership?

Or, you can keep AccountId instead?

[Luis Héctor Chávez, 2017/02/15 19:02:11]

Profile* const profile_;

(Chrome members have a trailing underscore, and having the 'const' there
prevents you from accidentally forgetting to initialize it).

[xzhou, 2017/02/16 18:34:50]

Done.

[xzhou, 2017/02/16 18:34:50]

Done.

[xzhou, 2017/02/16 18:34:50]

Done.

[xzhou, 2017/02/16 18:34:50]

Done.

   mojo::Binding<mojom::BootPhaseMonitorHost> binding_;
   std::unique_ptr<ArcInstanceThrottle> throttle_;
 
   base::ThreadChecker thread_checker_;
+  base::WeakPtrFactory<ArcBootPhaseMonitorBridge> weak_ptr_factory_;

[Luis Héctor Chávez, 2017/02/15 19:02:11]

nit: remove

[xzhou, 2017/02/16 18:34:50]

Done.

 
   DISALLOW_COPY_AND_ASSIGN(ArcBootPhaseMonitorBridge);
 };
 
 }  // namespace arc
 
 #endif  // CHROME_BROWSER_CHROMEOS_ARC_BOOT_PHASE_MONITOR_ARC_BOOT_PHASE_MONITOR_BRIDGE_H_