|
|
DescriptionRemove an unnecessary field in KeyboardController.
TEST=Build passes.
Review-Url: https://codereview.chromium.org/2692983006
Cr-Commit-Position: refs/heads/master@{#451953}
Committed: https://chromium.googlesource.com/chromium/src/+/000906e1a0fda481542568624e4c280d52acdce0
Patch Set 1 #Patch Set 2 : rebase #
Messages
Total messages: 26 (15 generated)
The CQ bit was checked by yhanada@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
yhanada@chromium.org changed reviewers: + sadrul@chromium.org
Hi sadrul@, PTAL. Thanks!
lgtm
Thank you for reviewing!
The CQ bit was checked by yhanada@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by yhanada@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Exceeded global retry quota
The CQ bit was checked by yhanada@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org Link to the patchset: https://codereview.chromium.org/2692983006/#ps20001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by yhanada@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487748716748420, "parent_rev": "3c96661cd7d066e3f4d6fe8b9760661ff76ea005", "commit_rev": "000906e1a0fda481542568624e4c280d52acdce0"}
Message was sent while issue was closed.
Description was changed from ========== Remove an unnecessary field in KeyboardController. TEST=Build passes. ========== to ========== Remove an unnecessary field in KeyboardController. TEST=Build passes. Review-Url: https://codereview.chromium.org/2692983006 Cr-Commit-Position: refs/heads/master@{#451953} Committed: https://chromium.googlesource.com/chromium/src/+/000906e1a0fda481542568624e4c... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/000906e1a0fda481542568624e4c... |