Increase timeout to reduce ios_web_inttests flake.

Increase timeout to reduce ios_web_inttests flake.

WKWebView needs some non trivial amount of time in order to load the test
pages (even if empty) for the tests in
browser_state_web_view_partition_inttest. Increasing the timeout in
|LoadTestWebPage| allows more time for the page to load.

BUG=684024
Review-Url: https://codereview.chromium.org/2692983004
Cr-Commit-Position: refs/heads/master@{#450896}
Committed: https://chromium.googlesource.com/chromium/src/+/3c9f07fc10a86242a0f38221ae73fd503dfcfd54

[michaeldo, 2017-02-15 07:21:00]

michaeldo@chromium.org changed reviewers:
+ eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2017-02-15 15:45:52]

lgtm

https://codereview.chromium.org/2692983004/diff/1/ios/web/browser_state_web_v...
File ios/web/browser_state_web_view_partition_inttest.mm (right):

https://codereview.chromium.org/2692983004/diff/1/ios/web/browser_state_web_v...
ios/web/browser_state_web_view_partition_inttest.mm:122: false,
base::TimeDelta::FromSeconds(1));
I thought on bots the default timeout is around 2 days:
https://cs.chromium.org/chromium/src/base/test/test_timeouts.cc?type=cs&q=kAl...

If that's not true, then please use testing::kWaitForPageLoadTimeout instead.

[michaeldo, 2017-02-16 07:42:13]

Description was changed from

==========
Increase timeout to reduce ios_web_inttests flake.

WKWebView needs some non trivial amount of time in order to load the test
pages (even if empty) for the tests in
browser_state_web_view_partition_inttest. Increasing the timeout to 1
second in |LoadTestWebPage| to allow more time for the page to load.

BUG=684024
==========

to

==========
Increase timeout to reduce ios_web_inttests flake.

WKWebView needs some non trivial amount of time in order to load the test
pages (even if empty) for the tests in
browser_state_web_view_partition_inttest. Increasing the timeout in
|LoadTestWebPage| allows more time for the page to load.

BUG=684024
==========

[michaeldo, 2017-02-16 07:55:32]

https://codereview.chromium.org/2692983004/diff/1/ios/web/browser_state_web_v...
File ios/web/browser_state_web_view_partition_inttest.mm (right):

https://codereview.chromium.org/2692983004/diff/1/ios/web/browser_state_web_v...
ios/web/browser_state_web_view_partition_inttest.mm:122: false,
base::TimeDelta::FromSeconds(1));
On 2017/02/15 15:45:52, Eugene But wrote:
> I thought on bots the default timeout is around 2 days:
>
https://cs.chromium.org/chromium/src/base/test/test_timeouts.cc?type=cs&q=kAl...
> 
> If that's not true, then please use testing::kWaitForPageLoadTimeout instead.

It does look like the timeout is very long for "Debug" mode or if a flag is
passed. I don't see any reference to the flag, but it looks possible that the
bots run in Debug. However, when I reduce the timeout locally, I am able to
reproduce the same bot failures. I updated the time to a constant of the
expected type rather than the suggested |testing::kWaitForPageLoadTimeout|. I
believe it's best to try the longer timeout and see if it effects the flake
since the current flake rate is quite extreme.

[michaeldo, 2017-02-16 07:56:58]

The CQ bit was checked by michaeldo@chromium.org

[michaeldo, 2017-02-16 07:56:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2692983004/#ps20001
(title: "Update timeout to use constant.")

[commit-bot: I haz the power, 2017-02-16 07:57:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 08:21:51]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487231818271850,
"parent_rev": "e8793e385f6bf50a48f5a5798af67e5c518ea8a4", "commit_rev":
"3c9f07fc10a86242a0f38221ae73fd503dfcfd54"}

[commit-bot: I haz the power, 2017-02-16 08:22:31]

Description was changed from

==========
Increase timeout to reduce ios_web_inttests flake.

WKWebView needs some non trivial amount of time in order to load the test
pages (even if empty) for the tests in
browser_state_web_view_partition_inttest. Increasing the timeout in
|LoadTestWebPage| allows more time for the page to load.

BUG=684024
==========

to

==========
Increase timeout to reduce ios_web_inttests flake.

WKWebView needs some non trivial amount of time in order to load the test
pages (even if empty) for the tests in
browser_state_web_view_partition_inttest. Increasing the timeout in
|LoadTestWebPage| allows more time for the page to load.

BUG=684024

Review-Url: https://codereview.chromium.org/2692983004
Cr-Commit-Position: refs/heads/master@{#450896}
Committed:
https://chromium.googlesource.com/chromium/src/+/3c9f07fc10a86242a0f38221ae73...
==========

[commit-bot: I haz the power, 2017-02-16 08:22:33]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3c9f07fc10a86242a0f38221ae73...