Replace SurfaceFactory in SynchronousCompositorFrameSink with CompositorFrameSinkSupport

Replace SurfaceFactory in SynchronousCompositorFrameSink with CompositorFrameSinkSupport

BUG=691684
Review-Url: https://codereview.chromium.org/2692963002
Cr-Commit-Position: refs/heads/master@{#450115}
Committed: https://chromium.googlesource.com/chromium/src/+/923a54c19fd80ea3fd7cafc7d2feec0ae3a939c1

[Saman Sami, 2017-02-13 19:48:50]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 19:49:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-02-13 19:50:10]

Description was changed from

==========
Replace SurfaceFactory in SynchronousCompositorFrameSink with
CompositorFrameSinkSupport

BUG=691684
==========

to

==========
Replace SurfaceFactory in SynchronousCompositorFrameSink with
CompositorFrameSinkSupport

BUG=691684
==========

[Saman Sami, 2017-02-13 19:50:10]

samans@chromium.org changed reviewers:
+ fsamuel@chromium.org

[Saman Sami, 2017-02-13 19:50:19]

PTAL

[Fady Samuel, 2017-02-13 19:53:08]

lgtm

[Saman Sami, 2017-02-13 19:53:45]

samans@chromium.org changed reviewers:
+ boliu@chromium.org

[Saman Sami, 2017-02-13 19:54:44]

boliu@: Please review all files.

[commit-bot: I haz the power, 2017-02-13 21:12:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 21:12:00]

Dry run: This issue passed the CQ dry run.

[Fady Samuel, 2017-02-13 21:24:14]

https://codereview.chromium.org/2692963002/diff/1/content/renderer/android/sy...
File content/renderer/android/synchronous_compositor_frame_sink.cc (right):

https://codereview.chromium.org/2692963002/diff/1/content/renderer/android/sy...
content/renderer/android/synchronous_compositor_frame_sink.cc:176: true /*
submits_to_display_compositor */));
Ahh this doesn't hang off the root, so this is false, actually.

[Saman Sami, 2017-02-13 21:29:12]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[Saman Sami, 2017-02-13 21:29:35]

https://codereview.chromium.org/2692963002/diff/1/content/renderer/android/sy...
File content/renderer/android/synchronous_compositor_frame_sink.cc (right):

https://codereview.chromium.org/2692963002/diff/1/content/renderer/android/sy...
content/renderer/android/synchronous_compositor_frame_sink.cc:176: true /*
submits_to_display_compositor */));
On 2017/02/13 21:24:14, Fady Samuel wrote:
> Ahh this doesn't hang off the root, so this is false, actually.

Done.

[commit-bot: I haz the power, 2017-02-13 21:30:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[boliu, 2017-02-13 21:34:24]

lgtm

[Saman Sami, 2017-02-13 21:35:34]

The CQ bit was unchecked by samans@chromium.org

[Saman Sami, 2017-02-13 21:35:51]

The CQ bit was checked by samans@chromium.org

[Saman Sami, 2017-02-13 21:35:51]

The patchset sent to the CQ was uploaded after l-g-t-m from fsamuel@chromium.org
Link to the patchset: https://codereview.chromium.org/2692963002/#ps20001
(title: "c")

[commit-bot: I haz the power, 2017-02-13 21:37:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 22:19:26]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487021751530160,
"parent_rev": "13af982ac673d665cb43a8a408d42256afece0c2", "commit_rev":
"923a54c19fd80ea3fd7cafc7d2feec0ae3a939c1"}

[commit-bot: I haz the power, 2017-02-13 22:20:07]

Description was changed from

==========
Replace SurfaceFactory in SynchronousCompositorFrameSink with
CompositorFrameSinkSupport

BUG=691684
==========

to

==========
Replace SurfaceFactory in SynchronousCompositorFrameSink with
CompositorFrameSinkSupport

BUG=691684

Review-Url: https://codereview.chromium.org/2692963002
Cr-Commit-Position: refs/heads/master@{#450115}
Committed:
https://chromium.googlesource.com/chromium/src/+/923a54c19fd80ea3fd7cafc7d2fe...
==========

[commit-bot: I haz the power, 2017-02-13 22:20:08]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/923a54c19fd80ea3fd7cafc7d2fe...