Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 2692963002: Replace SurfaceFactory in SynchronousCompositorFrameSink with CompositorFrameSinkSupport (Closed)

Created:
3 years, 10 months ago by Saman Sami
Modified:
3 years, 10 months ago
Reviewers:
Fady Samuel, boliu
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace SurfaceFactory in SynchronousCompositorFrameSink with CompositorFrameSinkSupport BUG=691684 Review-Url: https://codereview.chromium.org/2692963002 Cr-Commit-Position: refs/heads/master@{#450115} Committed: https://chromium.googlesource.com/chromium/src/+/923a54c19fd80ea3fd7cafc7d2feec0ae3a939c1

Patch Set 1 #

Total comments: 2

Patch Set 2 : submit_to_display_compositor must be false for child #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -42 lines) Patch
M content/renderer/android/synchronous_compositor_frame_sink.h View 4 chunks +12 lines, -8 lines 0 comments Download
M content/renderer/android/synchronous_compositor_frame_sink.cc View 1 7 chunks +21 lines, -34 lines 0 comments Download

Messages

Total messages: 22 (14 generated)
Saman Sami
PTAL
3 years, 10 months ago (2017-02-13 19:50:19 UTC) #5
Fady Samuel
lgtm
3 years, 10 months ago (2017-02-13 19:53:08 UTC) #6
Saman Sami
boliu@: Please review all files.
3 years, 10 months ago (2017-02-13 19:54:44 UTC) #8
Fady Samuel
https://codereview.chromium.org/2692963002/diff/1/content/renderer/android/synchronous_compositor_frame_sink.cc File content/renderer/android/synchronous_compositor_frame_sink.cc (right): https://codereview.chromium.org/2692963002/diff/1/content/renderer/android/synchronous_compositor_frame_sink.cc#newcode176 content/renderer/android/synchronous_compositor_frame_sink.cc:176: true /* submits_to_display_compositor */)); Ahh this doesn't hang off ...
3 years, 10 months ago (2017-02-13 21:24:14 UTC) #11
Saman Sami
https://codereview.chromium.org/2692963002/diff/1/content/renderer/android/synchronous_compositor_frame_sink.cc File content/renderer/android/synchronous_compositor_frame_sink.cc (right): https://codereview.chromium.org/2692963002/diff/1/content/renderer/android/synchronous_compositor_frame_sink.cc#newcode176 content/renderer/android/synchronous_compositor_frame_sink.cc:176: true /* submits_to_display_compositor */)); On 2017/02/13 21:24:14, Fady Samuel ...
3 years, 10 months ago (2017-02-13 21:29:35 UTC) #13
boliu
lgtm
3 years, 10 months ago (2017-02-13 21:34:24 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692963002/20001
3 years, 10 months ago (2017-02-13 21:37:04 UTC) #19
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 22:20:08 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/923a54c19fd80ea3fd7cafc7d2fe...

Powered by Google App Engine
This is Rietveld 408576698