Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2692953002: [Merge M57] Fix crash caused by middle clicking the privacy link in SSL interstitials (Closed)

Created:
3 years, 10 months ago by meacer
Modified:
3 years, 10 months ago
Reviewers:
estark
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[Merge M57] Fix crash caused by middle clicking the privacy link in SSL interstitials Middle clicking the privacy link initiates a new navigation instead of an in-page navigation which causes a crash. This CL changes the link to an in-page link to prevent that. BUG=682596 TBR=estark Review-Url: https://codereview.chromium.org/2673963004 Cr-Commit-Position: refs/heads/master@{#448753} (cherry picked from commit 5ecfaa1461f7ec8faf7bae9456cf2888a7608add) Review-Url: https://codereview.chromium.org/2692953002 . Cr-Commit-Position: refs/branch-heads/2987@{#483} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/23d4cde5a1addad4c462335124a5a367baec3399

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/security_interstitials/core/controller_client.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
meacer
3 years, 10 months ago (2017-02-13 19:48:40 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
23d4cde5a1addad4c462335124a5a367baec3399.

Powered by Google App Engine
This is Rietveld 408576698