Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1250)

Issue 2692943003: Rename www.example.com -> test.example.com for push resource (Closed)

Created:
3 years, 10 months ago by Zhongyi Shi
Modified:
3 years, 10 months ago
Reviewers:
Buck, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename www.example.com -> test.example.com for push resource so that it could be used for integration test. We have test certs valid for test.example.com only. This clean up will help set up for server push cancellation integration tests which need both setting up for certs nd pushed resource. Merge internal change: 147400096 BUG=232040 Review-Url: https://codereview.chromium.org/2692943003 Cr-Commit-Position: refs/heads/master@{#450182} Committed: https://chromium.googlesource.com/chromium/src/+/c767e3a0419746e45d73fa891ee9291a3a216a8e

Patch Set 1 #

Patch Set 2 : rename the normal response cache directory as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -168 lines) Patch
A + net/data/quic_http_response_cache_data/test.example.com/index.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + net/data/quic_http_response_cache_data/test.example.com/map.html View 1 1 chunk +1 line, -1 line 0 comments Download
D net/data/quic_http_response_cache_data/www.example.com/index.html View 1 1 chunk +0 lines, -63 lines 0 comments Download
D net/data/quic_http_response_cache_data/www.example.com/map.html View 1 1 chunk +0 lines, -65 lines 0 comments Download
A + net/data/quic_http_response_cache_data_with_push/test.example.com/favicon.ico View Binary file 0 comments Download
A + net/data/quic_http_response_cache_data_with_push/test.example.com/index.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + net/data/quic_http_response_cache_data_with_push/test.example.com/index2.html View 1 chunk +3 lines, -3 lines 0 comments Download
A + net/data/quic_http_response_cache_data_with_push/test.example.com/kitten-1.jpg View Binary file 0 comments Download
D net/data/quic_http_response_cache_data_with_push/www.example.com/favicon.ico View Binary file 0 comments Download
D net/data/quic_http_response_cache_data_with_push/www.example.com/index.html View 1 chunk +0 lines, -15 lines 0 comments Download
D net/data/quic_http_response_cache_data_with_push/www.example.com/index2.html View 1 chunk +0 lines, -16 lines 0 comments Download
D net/data/quic_http_response_cache_data_with_push/www.example.com/kitten-1.jpg View Binary file 0 comments Download
M net/tools/quic/quic_http_response_cache_test.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
Zhongyi Shi
3 years, 10 months ago (2017-02-13 20:45:25 UTC) #3
Zhongyi Shi
The internal CL has been checked in. PTAL!
3 years, 10 months ago (2017-02-13 23:24:51 UTC) #11
Ryan Hamilton
lgtm
3 years, 10 months ago (2017-02-13 23:26:24 UTC) #12
Buck
lgtm
3 years, 10 months ago (2017-02-13 23:43:17 UTC) #13
Buck
lgtm
3 years, 10 months ago (2017-02-13 23:43:19 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692943003/20001
3 years, 10 months ago (2017-02-14 01:07:55 UTC) #18
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 01:15:42 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c767e3a0419746e45d73fa891ee9...

Powered by Google App Engine
This is Rietveld 408576698