Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 2692933004: Print pak sizes on a per-header basis in resource_sizes.py (Closed)

Created:
3 years, 10 months ago by agrieve
Modified:
3 years, 10 months ago
Reviewers:
estevenson
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Print pak sizes on a per-header basis in resource_sizes.py Example output: HEADER UNCOMPRESSED SIZE gen/chrome/grit/generated_resources.h 2.55m 36.86% gen/components/strings/grit/components_strings.h 1.82m 26.30% gen/ui/resources/grit/webui_resources.h 610.10k 8.61% gen/components/grit/components_resources.h 558.00k 7.88% gen/content/app/strings/grit/content_strings.h 247.47k 3.49% gen/blink/public/resources/grit/blink_resources.h 243.74k 3.44% gen/chrome/grit/browser_resources.h 223.38k 3.15% gen/chrome/grit/theme_resources.h 137.08k 1.94% gen/ui/strings/grit/ui_strings.h 110.22k 1.56% unknown 94.92k 1.34% gen/content/grit/content_resources.h 94.80k 1.34% gen/chrome/grit/google_chrome_strings.h 83.09k 1.17% gen/chrome/grit/net_internals_resources.h 45.38k 0.64% gen/components/strings/grit/components_google_chrome_strings.h 28.62k 0.40% gen/components/grit/components_scaled_resources.h 26.26k 0.37% gen/ui/resources/grit/ui_resources.h 22.17k 0.31% gen/blink/public/resources/grit/blink_image_resources.h 21.62k 0.31% Review-Url: https://codereview.chromium.org/2692933004 Cr-Commit-Position: refs/heads/master@{#450774} Committed: https://chromium.googlesource.com/chromium/src/+/068272b789d612b69453c24f47dd0d9f4708aedf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -10 lines) Patch
M build/android/resource_sizes.py View 3 chunks +30 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
agrieve
On 2017/02/14 20:21:39, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:estevenson@chromium.org 📔
3 years, 10 months ago (2017-02-14 20:21:58 UTC) #3
estevenson
lgtm
3 years, 10 months ago (2017-02-14 20:34:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692933004/1
3 years, 10 months ago (2017-02-15 16:39:54 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 19:38:30 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/068272b789d612b69453c24f47dd...

Powered by Google App Engine
This is Rietveld 408576698