[Payments] Adjust the UI fit the mocks better

[Payments] Adjust the UI fit the mocks better

Also adds the leading footer view, used to add "* indicates a required
field" on editors.

Screenshot 1: https://drive.google.com/a/chromium.org/file/d/0B3xzZ-vFr2LRelhwQWtVZHdOblU/view?usp=sharing
Screenshot 2: https://drive.google.com/file/d/0B3xzZ-vFr2LRUkd2eHdNLXd2eFE/view?usp=sharing

BUG=687601
TEST=existing

Review-Url: https://codereview.chromium.org/2692923011
Cr-Commit-Position: refs/heads/master@{#451465}
Committed: https://chromium.googlesource.com/chromium/src/+/4ba9f702ce790f1a7a55cdf1ef1a7c6e00f43cf4

[Mathieu, 2017-02-17 20:12:49]

Patchset #1 (id:1) has been deleted

[Mathieu, 2017-02-17 20:12:57]

The CQ bit was checked by mathp@chromium.org to run a CQ dry run

[Mathieu, 2017-02-17 20:13:02]

mathp@chromium.org changed reviewers:
+ rouslan@chromium.org

[Mathieu, 2017-02-17 20:13:03]

Hi Rouslan, PTAL

[commit-bot: I haz the power, 2017-02-17 20:14:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mathieu, 2017-02-17 20:15:57]

Description was changed from

==========
[Payments] Adjust the UI fit the mocks better

Also adds the leading footer view, used to add "* indicates a required
field" on editors.

BUG=687601
TEST=existing
==========

to

==========
[Payments] Adjust the UI fit the mocks better

Also adds the leading footer view, used to add "* indicates a required
field" on editors.

Screenshot 1:
https://drive.google.com/a/chromium.org/file/d/0B3xzZ-vFr2LRelhwQWtVZHdOblU/v...
Screenshot 2:
https://drive.google.com/file/d/0B3xzZ-vFr2LRUkd2eHdNLXd2eFE/view?usp=sharing

BUG=687601
TEST=existing
==========

[commit-bot: I haz the power, 2017-02-17 20:34:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 20:34:35]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Mathieu, 2017-02-18 00:32:46]

The CQ bit was checked by mathp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-18 00:34:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 02:38:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 02:38:00]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[please use gerrit instead, 2017-02-18 15:06:14]

lgtm % nit

https://codereview.chromium.org/2692923011/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/payments/payment_request_sheet_controller.h
(right):

https://codereview.chromium.org/2692923011/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/payment_request_sheet_controller.h:38: virtual
std::unique_ptr<views::View> CreateLeadingFooterView();
Would it be possible to add ASCII art similar to CreatePaymentView()?

[Mathieu, 2017-02-18 15:41:02]

Thanks

https://codereview.chromium.org/2692923011/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/payments/payment_request_sheet_controller.h
(right):

https://codereview.chromium.org/2692923011/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/payment_request_sheet_controller.h:38: virtual
std::unique_ptr<views::View> CreateLeadingFooterView();
On 2017/02/18 15:06:14, rouslan wrote:
> Would it be possible to add ASCII art similar to CreatePaymentView()?

Thanks, I've added it in editor_view_controller.cc

[Mathieu, 2017-02-18 15:41:06]

The CQ bit was checked by mathp@chromium.org

[Mathieu, 2017-02-18 15:41:07]

The patchset sent to the CQ was uploaded after l-g-t-m from rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/2692923011/#ps40001
(title: "adds ascii art")

[commit-bot: I haz the power, 2017-02-18 15:41:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 16:19:40]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487432466516450,
"parent_rev": "9a84244d0aabd3d3ee775adf82dc9acb2fefac31", "commit_rev":
"4ba9f702ce790f1a7a55cdf1ef1a7c6e00f43cf4"}

[commit-bot: I haz the power, 2017-02-18 16:20:14]

Description was changed from

==========
[Payments] Adjust the UI fit the mocks better

Also adds the leading footer view, used to add "* indicates a required
field" on editors.

Screenshot 1:
https://drive.google.com/a/chromium.org/file/d/0B3xzZ-vFr2LRelhwQWtVZHdOblU/v...
Screenshot 2:
https://drive.google.com/file/d/0B3xzZ-vFr2LRUkd2eHdNLXd2eFE/view?usp=sharing

BUG=687601
TEST=existing
==========

to

==========
[Payments] Adjust the UI fit the mocks better

Also adds the leading footer view, used to add "* indicates a required
field" on editors.

Screenshot 1:
https://drive.google.com/a/chromium.org/file/d/0B3xzZ-vFr2LRelhwQWtVZHdOblU/v...
Screenshot 2:
https://drive.google.com/file/d/0B3xzZ-vFr2LRUkd2eHdNLXd2eFE/view?usp=sharing

BUG=687601
TEST=existing

Review-Url: https://codereview.chromium.org/2692923011
Cr-Commit-Position: refs/heads/master@{#451465}
Committed:
https://chromium.googlesource.com/chromium/src/+/4ba9f702ce790f1a7a55cdf1ef1a...
==========

[commit-bot: I haz the power, 2017-02-18 16:20:15]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4ba9f702ce790f1a7a55cdf1ef1a...