Rename m_globalWeakCallbacks to m_weakCallbacks

Rename m_globalWeakCallbacks to m_weakCallbacks

Now that we don't have a concept of thread-local weak processing,
we can just rename global weak processing to weak processing.

BUG=671856
Review-Url: https://codereview.chromium.org/2692923007
Cr-Commit-Position: refs/heads/master@{#453188}
Committed: https://chromium.googlesource.com/chromium/src/+/39df8cdf874294a0aef7937c776d683a7081ecbc

[haraken, 2017-02-15 08:18:05]

haraken@chromium.org changed reviewers:
+ sigbjornf@opera.com

[haraken, 2017-02-15 08:18:05]

PTAL

[sof, 2017-02-15 14:34:05]

lgtm

[haraken, 2017-02-15 14:48:07]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2017-02-15 14:48:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 16:29:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 16:29:52]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[haraken, 2017-02-27 04:04:33]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2017-02-27 04:04:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 06:55:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 06:55:58]

Failed to apply patch for third_party/WebKit/Source/platform/heap/Heap.h:
While running git apply --index -p1;
  error: patch failed: third_party/WebKit/Source/platform/heap/Heap.h:279
  error: third_party/WebKit/Source/platform/heap/Heap.h: patch does not apply

Patch:       third_party/WebKit/Source/platform/heap/Heap.h
Index: third_party/WebKit/Source/platform/heap/Heap.h
diff --git a/third_party/WebKit/Source/platform/heap/Heap.h
b/third_party/WebKit/Source/platform/heap/Heap.h
index
ee57a324aee318afc884f8d5a87f278b680c00b8..a2675ed68826a51f380727a3ff41ebb384799b30
100644
--- a/third_party/WebKit/Source/platform/heap/Heap.h
+++ b/third_party/WebKit/Source/platform/heap/Heap.h
@@ -279,9 +279,7 @@ class PLATFORM_EXPORT ThreadHeap {
   CallbackStack* postMarkingCallbackStack() const {
     return m_postMarkingCallbackStack.get();
   }
-  CallbackStack* globalWeakCallbackStack() const {
-    return m_globalWeakCallbackStack.get();
-  }
+  CallbackStack* weakCallbackStack() const { return m_weakCallbackStack.get();
}
   CallbackStack* ephemeronStack() const { return m_ephemeronStack.get(); }
 
   void attach(ThreadState*);
@@ -354,7 +352,7 @@ class PLATFORM_EXPORT ThreadHeap {
   // Remove an item from the weak callback work list and call the callback
   // with the visitor and the closure pointer.  Returns false when there is
   // nothing more to do.
-  bool popAndInvokeGlobalWeakCallback(Visitor*);
+  bool popAndInvokeWeakCallback(Visitor*);
 
   // Register an ephemeron table for fixed-point iteration.
   void registerWeakTable(void* containerObject,
@@ -409,7 +407,7 @@ class PLATFORM_EXPORT ThreadHeap {
 
   void processMarkingStack(Visitor*);
   void postMarkingProcessing(Visitor*);
-  void globalWeakProcessing(Visitor*);
+  void weakProcessing(Visitor*);
 
   void preGC();
   void postGC(BlinkGC::GCType);
@@ -468,7 +466,7 @@ class PLATFORM_EXPORT ThreadHeap {
   std::unique_ptr<PagePool> m_freePagePool;
   std::unique_ptr<CallbackStack> m_markingStack;
   std::unique_ptr<CallbackStack> m_postMarkingCallbackStack;
-  std::unique_ptr<CallbackStack> m_globalWeakCallbackStack;
+  std::unique_ptr<CallbackStack> m_weakCallbackStack;
   std::unique_ptr<CallbackStack> m_ephemeronStack;
   BlinkGC::GCReason m_lastGCReason;
   StackFrameDepth m_stackFrameDepth;

[sof, 2017-02-27 08:48:53]

(needs a rebase)

[haraken, 2017-02-27 09:19:10]

The CQ bit was checked by haraken@chromium.org

[haraken, 2017-02-27 09:19:11]

The patchset sent to the CQ was uploaded after l-g-t-m from sigbjornf@opera.com
Link to the patchset: https://codereview.chromium.org/2692923007/#ps40001
(title: "temp")

[commit-bot: I haz the power, 2017-02-27 09:19:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 11:11:39]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488187150931400,
"parent_rev": "16bd9a5826c9ff951b7f7def34c619b3a2d31858", "commit_rev":
"39df8cdf874294a0aef7937c776d683a7081ecbc"}

[commit-bot: I haz the power, 2017-02-27 11:12:14]

Description was changed from

==========
Rename m_globalWeakCallbacks to m_weakCallbacks

Now that we don't have a concept of thread-local weak processing,
we can just rename global weak processing to weak processing.

BUG=671856
==========

to

==========
Rename m_globalWeakCallbacks to m_weakCallbacks

Now that we don't have a concept of thread-local weak processing,
we can just rename global weak processing to weak processing.

BUG=671856

Review-Url: https://codereview.chromium.org/2692923007
Cr-Commit-Position: refs/heads/master@{#453188}
Committed:
https://chromium.googlesource.com/chromium/src/+/39df8cdf874294a0aef7937c776d...
==========

[commit-bot: I haz the power, 2017-02-27 11:12:16]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/39df8cdf874294a0aef7937c776d...