Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2692923006: Add job id to JobEventDetails. (Closed)

Created:
3 years, 10 months ago by skau
Modified:
3 years, 10 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add job id to JobEventDetails. Adding job id to JobEventDetails makes it easier to track jobs after they've been queued. BUG=684853 Review-Url: https://codereview.chromium.org/2692923006 Cr-Commit-Position: refs/heads/master@{#450766} Committed: https://chromium.googlesource.com/chromium/src/+/3fadb49c64f97201f9a328052a11ad07d01e9cbd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -20 lines) Patch
M chrome/browser/printing/print_job.h View 3 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/printing/print_job.cc View 4 chunks +7 lines, -9 lines 0 comments Download
M chrome/browser/printing/print_job_worker.cc View 6 chunks +10 lines, -7 lines 0 comments Download
M printing/printing_context.h View 2 chunks +5 lines, -0 lines 0 comments Download
M printing/printing_context_chromeos.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
skau
Job ids are currently only used on Chrome OS but they are available on all ...
3 years, 10 months ago (2017-02-15 17:03:04 UTC) #6
Vitaly Buka (NO REVIEWS)
lgtm
3 years, 10 months ago (2017-02-15 18:55:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692923006/1
3 years, 10 months ago (2017-02-15 18:56:36 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 19:24:21 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3fadb49c64f97201f9a328052a11...

Powered by Google App Engine
This is Rietveld 408576698