Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2692913003:
Move save/generate password options to the top of the context menu (Closed)
|
Created:
3 years, 10 months ago by edwardjung Modified:
3 years, 10 months ago Reviewers:
lazyboy CC:
chromium-reviews, srahim+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMove save/generate password options to the top of the context menu
For screenshots see:
https://bugs.chromium.org/p/chromium/issues/detail?id=687252#c3
BUG=687252
Review-Url: https://codereview.chromium.org/2692913003
Cr-Commit-Position: refs/heads/master@{#450511}
Committed: https://chromium.googlesource.com/chromium/src/+/6d68b705395f7adb0608d1898d3ceffde6583f68
Patch Set 1 #Patch Set 2 : Merge #Patch Set 3 : Revert generated_resources.grd #
Total comments: 2
Patch Set 4 : Simplify logic to not rely on indexes #Messages
Total messages: 19 (13 generated)
The CQ bit was checked by edwardjung@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Move save/generate password options to the top of the context menu BUG=687252 ========== to ========== Move save/generate password options to the top of the context menu For screenshots see: https://bugs.chromium.org/p/chromium/issues/detail?id=687252#c3 BUG=687252 ==========
edwardjung@chromium.org changed reviewers: + lazyboy@chromium.org
PTAL at this change to improve the experience for HTML password fields. Thanks. Edward
https://codereview.chromium.org/2692913003/diff/40001/chrome/browser/renderer... File chrome/browser/renderer_context_menu/render_view_context_menu.cc (right): https://codereview.chromium.org/2692913003/diff/40001/chrome/browser/renderer... chrome/browser/renderer_context_menu/render_view_context_menu.cc:1472: menu_model_.InsertItemWithStringIdAt(menu_position, instead of using mix of menu_position, ++menu_position and menu_position+1, could we always use menu_position++ as parameter? However, I feel like this better be avoided to explicitly specify position 0 for these kind of items b/c it will encourage multiple group items to fight for a spot. And it will be harder to understand by reading the code where a group will end up in. Any group adding items later can steal the spot 0. If we moved AppendPasswordItems at the top of RenderViewContextMenu::InitMenu() after calling Base::InitMenu, would that be enough? Currently only custom items and toolkit delegate items will come before AppendPasswordItems
https://codereview.chromium.org/2692913003/diff/40001/chrome/browser/renderer... File chrome/browser/renderer_context_menu/render_view_context_menu.cc (right): https://codereview.chromium.org/2692913003/diff/40001/chrome/browser/renderer... chrome/browser/renderer_context_menu/render_view_context_menu.cc:1472: menu_model_.InsertItemWithStringIdAt(menu_position, > If we moved AppendPasswordItems at the top of RenderViewContextMenu::InitMenu() > after calling Base::InitMenu, would that be enough? Currently only custom items > and toolkit delegate items will come before AppendPasswordItems Of course. yes this is much simpler and removes the need for inserting at specific indexes. Thanks! I tweaked the logic for displaying the separator.
thanks lgtm
The CQ bit was checked by edwardjung@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by edwardjung@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487113007719470,
"parent_rev": "4b747aadfaf157b30dff0d5eb499c39d3f45c5b9", "commit_rev":
"6d68b705395f7adb0608d1898d3ceffde6583f68"}
Message was sent while issue was closed.
Description was changed from ========== Move save/generate password options to the top of the context menu For screenshots see: https://bugs.chromium.org/p/chromium/issues/detail?id=687252#c3 BUG=687252 ========== to ========== Move save/generate password options to the top of the context menu For screenshots see: https://bugs.chromium.org/p/chromium/issues/detail?id=687252#c3 BUG=687252 Review-Url: https://codereview.chromium.org/2692913003 Cr-Commit-Position: refs/heads/master@{#450511} Committed: https://chromium.googlesource.com/chromium/src/+/6d68b705395f7adb0608d1898d3c... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/6d68b705395f7adb0608d1898d3c... |
