content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java - Issue 2692903002: Don't show media controls when there is a persistent video.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

Issue 2692903002: Don't show media controls when there is a persistent video. (Closed)

Patch Set: cleanup and tests Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/web_contents/web_contents_impl.h ('K') | « content/browser/web_contents/web_contents_impl.cc ('k') | content/public/android/java/src/org/chromium/content_public/browser/WebContents.java » ('j') | content/public/common/common_param_traits_macros.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java b/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

index b7dc50638047944bc3d5274028ae1d971e4d2ee6..3b0938ee05b5c4bb34f8f2b47c2f129c22e85bfc 100644

--- a/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

+++ b/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

@@ -510,6 +510,11 @@ import java.util.UUID;

nativeDismissTextHandles(mNativeWebContentsAndroid);

}

+ @Override

+ public void setHasPersistentVideo(boolean value) {

+ nativeSetHasPersistentVideo(mNativeWebContentsAndroid, value);

+ }

@CalledByNative

private final void setMediaSession(MediaSessionImpl mediaSession) {

mMediaSession = mediaSession;

@@ -599,4 +604,5 @@ import java.util.UUID;

String url, boolean isFavicon, int maxBitmapSize,

boolean bypassCache, ImageDownloadCallback callback);

private native void nativeDismissTextHandles(long nativeWebContentsAndroid);

+ private native void nativeSetHasPersistentVideo(long nativeWebContentsAndroid, boolean value);

}