content/public/common/common_param_traits_macros.h - Issue 2692903002: Don't show media controls when there is a persistent video.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/common/common_param_traits_macros.h

Issue 2692903002: Don't show media controls when there is a persistent video. (Closed)

Patch Set: cleanup and tests Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/public/common/common_param_traits_macros.h

diff --git a/content/public/common/common_param_traits_macros.h b/content/public/common/common_param_traits_macros.h

index ab84e813e2e11d6dc74aa07fed60757372e9101d..95d801c43c700a8c31c64d83a5d5ce3e3710b0a2 100644

--- a/content/public/common/common_param_traits_macros.h

+++ b/content/public/common/common_param_traits_macros.h

@@ -240,6 +240,7 @@ IPC_STRUCT_TRAITS_BEGIN(content::WebPreferences)

IPC_STRUCT_TRAITS_MEMBER(progress_bar_completion)

IPC_STRUCT_TRAITS_MEMBER(spellcheck_enabled_by_default)

IPC_STRUCT_TRAITS_MEMBER(video_fullscreen_orientation_lock_enabled)

+ IPC_STRUCT_TRAITS_MEMBER(media_controls_enabled)

nasko 2017/02/13 22:28:42 Please order this the same way it is inside the st

mlamouri (slow - plz ping) 2017/02/14 11:19:46 Oups. I first wrote the implementation as Android

#else // defined(OS_ANDROID)

IPC_STRUCT_TRAITS_MEMBER(cross_origin_media_playback_requires_user_gesture)

#endif // defined(OS_ANDROID)