Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 2692903002: Don't show media controls when there is a persistent video. (Closed)
Patch Set: cleanup and tests Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.h
diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h
index 72e4b50cdbd0727418fbd6913c29e6bbc2e57e2c..f718f391669cf8792e644cb6eac3c6a03d527bfc 100644
--- a/content/browser/web_contents/web_contents_impl.h
+++ b/content/browser/web_contents/web_contents_impl.h
@@ -564,6 +564,7 @@ class CONTENT_EXPORT WebContentsImpl
bool IsOverridingUserAgent() override;
bool IsJavaScriptDialogShowing() const override;
bool HideDownloadUI() const override;
+ bool HasPersistentVideo() const override;
// NavigatorDelegate ---------------------------------------------------------
@@ -793,6 +794,9 @@ class CONTENT_EXPORT WebContentsImpl
void IncrementBluetoothConnectedDeviceCount();
void DecrementBluetoothConnectedDeviceCount();
+ // Called when the WebContents gains or loses a persistent video.
+ void SetHasPersistentVideo(bool value);
+
#if defined(OS_ANDROID)
// Called by FindRequestManager when all of the find match rects are in.
void NotifyFindMatchRectsReply(int version,
@@ -1174,6 +1178,10 @@ class CONTENT_EXPORT WebContentsImpl
// certificate via --allow-insecure-localhost.
void ShowInsecureLocalhostWarningIfNeeded();
+ // Notify the RenderViewHost that the preferences have changed. This will send
nasko 2017/02/13 22:28:42 Let's avoid using RenderViewHost, as it is current
mlamouri (slow - plz ping) 2017/02/14 11:19:46 Done.
+ // an IPC to all the renderer process associated with this WebContents.
+ void NotifyPreferencesChanged();
+
// Data for core operation ---------------------------------------------------
// Delegate for notifying our owner about stuff. Not owned by us.
@@ -1500,6 +1508,8 @@ class CONTENT_EXPORT WebContentsImpl
int currently_playing_video_count_ = 0;
+ bool has_persistent_video_ = false;
+
base::WeakPtrFactory<WebContentsImpl> loading_weak_factory_;
base::WeakPtrFactory<WebContentsImpl> weak_factory_;

Powered by Google App Engine
This is Rietveld 408576698