Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(979)

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControls.h

Issue 2692903002: Don't show media controls when there is a persistent video. (Closed)
Patch Set: rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/shadow/MediaControls.h
diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControls.h b/third_party/WebKit/Source/core/html/shadow/MediaControls.h
index b2046b6cbf97cd441b9544e5aaa4bb1c7126c58c..74805310d50a486754080001c24d9494b9eecfb0 100644
--- a/third_party/WebKit/Source/core/html/shadow/MediaControls.h
+++ b/third_party/WebKit/Source/core/html/shadow/MediaControls.h
@@ -110,6 +110,13 @@ class CORE_EXPORT MediaControls final : public HTMLDivElement {
refreshCastButtonVisibility();
}
+ // TODO(mlamouri): this method is needed in order to notify the controls that
+ // the `mediaControlsEnabled` setting has changed.
+ void onMediaControlsEnabledChange() {
+ // There is no update because only the overlay is expected to change.
+ refreshCastButtonVisibilityWithoutUpdate();
+ }
+
DECLARE_VIRTUAL_TRACE();
private:
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLMediaElement.cpp ('k') | third_party/WebKit/Source/core/html/shadow/MediaControls.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698