Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: third_party/WebKit/Source/core/html/shadow/MediaControls.h

Issue 2692903002: Don't show media controls when there is a persistent video. (Closed)
Patch Set: rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2011, 2012 Apple Inc. All rights reserved.
3 * Copyright (C) 2011, 2012 Google Inc. All rights reserved. 3 * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 void onRemotePlaybackAvailabilityChanged() { refreshCastButtonVisibility(); } 103 void onRemotePlaybackAvailabilityChanged() { refreshCastButtonVisibility(); }
104 void onRemotePlaybackConnecting() { startedCasting(); } 104 void onRemotePlaybackConnecting() { startedCasting(); }
105 void onRemotePlaybackDisconnected() { stoppedCasting(); } 105 void onRemotePlaybackDisconnected() { stoppedCasting(); }
106 106
107 // TODO(mlamouri): this method is needed in order to notify the controls that 107 // TODO(mlamouri): this method is needed in order to notify the controls that
108 // the attribute have changed. 108 // the attribute have changed.
109 void onDisableRemotePlaybackAttributeChanged() { 109 void onDisableRemotePlaybackAttributeChanged() {
110 refreshCastButtonVisibility(); 110 refreshCastButtonVisibility();
111 } 111 }
112 112
113 // TODO(mlamouri): this method is needed in order to notify the controls that
114 // the `mediaControlsEnabled` setting has changed.
115 void onMediaControlsEnabledChange() {
116 // There is no update because only the overlay is expected to change.
117 refreshCastButtonVisibilityWithoutUpdate();
118 }
119
113 DECLARE_VIRTUAL_TRACE(); 120 DECLARE_VIRTUAL_TRACE();
114 121
115 private: 122 private:
116 friend class MediaControlsMediaEventListener; 123 friend class MediaControlsMediaEventListener;
117 friend class MediaControlsOrientationLockDelegateTest; 124 friend class MediaControlsOrientationLockDelegateTest;
118 friend class MediaControlsTest; 125 friend class MediaControlsTest;
119 126
120 void invalidate(Element*); 127 void invalidate(Element*);
121 128
122 class BatchedControlUpdate; 129 class BatchedControlUpdate;
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
214 int m_panelWidth; 221 int m_panelWidth;
215 222
216 bool m_keepShowingUntilTimerFires : 1; 223 bool m_keepShowingUntilTimerFires : 1;
217 }; 224 };
218 225
219 DEFINE_ELEMENT_TYPE_CASTS(MediaControls, isMediaControls()); 226 DEFINE_ELEMENT_TYPE_CASTS(MediaControls, isMediaControls());
220 227
221 } // namespace blink 228 } // namespace blink
222 229
223 #endif 230 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLMediaElement.cpp ('k') | third_party/WebKit/Source/core/html/shadow/MediaControls.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698