Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2692893002: [UI Strings] Remove unused strings in ui/strings/ui_strings.grd (Closed)

Created:
3 years, 10 months ago by Mathieu
Modified:
3 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, srahim+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[UI Strings] Remove unused strings in ui/strings/ui_strings.grd BUG=690075 TEST=builds Review-Url: https://codereview.chromium.org/2692893002 Cr-Commit-Position: refs/heads/master@{#450029} Committed: https://chromium.googlesource.com/chromium/src/+/46445b7459ec3f31ee268d6067bce5ea2e721144

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M ui/strings/ui_strings.grd View 1 3 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
Mathieu
Hi Scott, PTAL
3 years, 10 months ago (2017-02-13 15:01:50 UTC) #4
sky
LGTM
3 years, 10 months ago (2017-02-13 18:00:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692893002/20001
3 years, 10 months ago (2017-02-13 18:04:53 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 18:43:04 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/46445b7459ec3f31ee268d6067bc...

Powered by Google App Engine
This is Rietveld 408576698