Enable support for coredump archiving on windows

Enable support for coredump archiving on windows

BUG=https://github.com/dart-lang/sdk/issues/28648
R=vegorov@google.com

Committed: https://github.com/dart-lang/sdk/commit/affb7865826160978c43a112b3da8c95cd22fb72

[kustermann, 2017-02-13 13:09:03]

kustermann@google.com changed reviewers:
+ fschneider@google.com, vegorov@google.com

[kustermann, 2017-02-13 13:09:03]

This CL works on my windows machine.

For one buildbot VM I tried it upon, the registry setting had no effect and the
dump wasn't put into the directory.

I'm not quite sure what the issue there is yet.

[kustermann, 2017-02-14 13:41:58]

Patchset #2 (id:20001) has been deleted

[kustermann, 2017-02-14 14:00:38]

Patchset #2 (id:40001) has been deleted

[kustermann, 2017-02-14 14:02:25]

Please take a look now.

[Vyacheslav Egorov (Google), 2017-02-14 15:24:07]

LGTM!

https://codereview.chromium.org/2692883002/diff/60001/tools/utils.py
File tools/utils.py (right):

https://codereview.chromium.org/2692883002/diff/60001/tools/utils.py#newcode736
tools/utils.py:736: # Depending on wether we're in cygwin or not we use a
different import.
whether

https://codereview.chromium.org/2692883002/diff/60001/tools/utils.py#newcode755
tools/utils.py:755: wer = self.winreg.CreateKeyEx(
maybe 

with CreateKeyEx() as wer: 
  ...

https://codereview.chromium.org/2692883002/diff/60001/tools/utils.py#newcode790
tools/utils.py:790: # We remove the local dumps settings we have afte running
the tests.
after

https://codereview.chromium.org/2692883002/diff/60001/tools/utils.py#newcode795
tools/utils.py:795: try:
maybe

with ... as wer_localdumps:
 ...

[kustermann, 2017-02-14 15:34:28]

https://codereview.chromium.org/2692883002/diff/60001/tools/utils.py
File tools/utils.py (right):

https://codereview.chromium.org/2692883002/diff/60001/tools/utils.py#newcode736
tools/utils.py:736: # Depending on wether we're in cygwin or not we use a
different import.
On 2017/02/14 15:24:07, Vyacheslav Egorov (Google) wrote:
> whether

Done.

https://codereview.chromium.org/2692883002/diff/60001/tools/utils.py#newcode755
tools/utils.py:755: wer = self.winreg.CreateKeyEx(
On 2017/02/14 15:24:07, Vyacheslav Egorov (Google) wrote:
> maybe 
> 
> with CreateKeyEx() as wer: 
>   ...
> 

Done.

https://codereview.chromium.org/2692883002/diff/60001/tools/utils.py#newcode790
tools/utils.py:790: # We remove the local dumps settings we have afte running
the tests.
On 2017/02/14 15:24:07, Vyacheslav Egorov (Google) wrote:
> after

Done.

https://codereview.chromium.org/2692883002/diff/60001/tools/utils.py#newcode795
tools/utils.py:795: try:
On 2017/02/14 15:24:07, Vyacheslav Egorov (Google) wrote:
> maybe
> 
> with ... as wer_localdumps:
>  ...

Done.

[kustermann, 2017-02-14 15:34:39]

Description was changed from

==========
Enable support for coredump archiving on windows

BUG=https://github.com/dart-lang/sdk/issues/28648
==========

to

==========
Enable support for coredump archiving on windows

BUG=https://github.com/dart-lang/sdk/issues/28648
R=vegorov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/affb7865826160978c43a112b3da8c95cd22fb72
==========

[kustermann, 2017-02-14 15:34:40]

Committed patchset #3 (id:80001) manually as
affb7865826160978c43a112b3da8c95cd22fb72 (presubmit successful).