Enable support for coredump archiving on windows

tools/testing/dart/test_progress.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test_progress;
 
 import "dart:async";
 import "dart:io";
 import "dart:io" as io;
 import "dart:convert" show JSON;
@@ skipping 295 matching lines @@
 
   void _writeTestOutcomeRecord(Map record) {
     if (_sink == null) {
       _sink = new File(TestUtils.testOutcomeFileName())
           .openWrite(mode: FileMode.APPEND);
     }
     _sink.write("${JSON.encode(record)}\n");
   }
 }
 
-class UnexpectedCrashDumpArchiver extends EventListener {
+class UnexpectedCrashLogger extends EventListener {
   final archivedBinaries = <String, String>{};
 
   void done(TestCase test) {
     if (test.unexpectedOutput &&
         test.result == Expectation.CRASH &&
         test.lastCommandExecuted is ProcessCommand) {
-      final name = "core.${test.lastCommandOutput.pid}";
-      final file = new File(name);
-      final exists = file.existsSync();
-      if (exists) {
-        final lastCommand = test.lastCommandExecuted as ProcessCommand;
-        // We have a coredump for the process. This coredump will be archived by
-        // CoreDumpArchiver (see tools/utils.py). For debugging purposes we
-        // need to archive the crashed binary as well. To simplify the
-        // archiving code we simply copy binaries into current folder next to
-        // core dumps and name them `core.${mode}_${arch}_${binary_name}`.
-        final binName = lastCommand.executable;
-        final binFile = new File(binName);
-        final binBaseName = new Path(binName).filename;
-        if (!archivedBinaries.containsKey(binName) &&
-            binFile.existsSync()) {
-          final mode = test.configuration['mode'];
-          final arch = test.configuration['arch'];
-          final archived = "binary.${mode}_${arch}_${binBaseName}";
-          TestUtils.copyFile(new Path(binName), new Path(archived));
-          archivedBinaries[binName] = archived;
-        }
+      final pid = "${test.lastCommandOutput.pid}";
+      final lastCommand = test.lastCommandExecuted as ProcessCommand;
 
-        if (archivedBinaries.containsKey(binName)) {
-          // We have found and copied the binary.
-          var coredumpsList;
+      // We might have a coredump for the process. This coredump will be
+      // archived by CoreDumpArchiver (see tools/utils.py).
+      //
+      // For debugging purposes we need to archive the crashed binary as well.
+      //
+      // To simplify the archiving code we simply copy binaries into current
+      // folder next to core dumps and name them
+      // `binary.${mode}_${arch}_${binary_name}`.
+      final binName = lastCommand.executable;
+      final binFile = new File(binName);
+      final binBaseName = new Path(binName).filename;
+      if (!archivedBinaries.containsKey(binName) &&
+          binFile.existsSync()) {
+        final mode = test.configuration['mode'];
+        final arch = test.configuration['arch'];
+        final archived = "binary.${mode}_${arch}_${binBaseName}";
+        TestUtils.copyFile(new Path(binName), new Path(archived));
+        archivedBinaries[binName] = archived;
+      }
+
+      if (archivedBinaries.containsKey(binName)) {
+        // We have found and copied the binary.
+        var unexpectedCrashesFile;
+        try {
+          unexpectedCrashesFile =
+              new File('unexpected-crashes').openSync(mode: FileMode.APPEND);
+          unexpectedCrashesFile.writeStringSync(
+              "${test.displayName},${pid},${archivedBinaries[binName]}\n");
+        } catch (e) {
+          print('Failed to add crash to unexpected-crashes list: ${e}');
+        } finally {
           try {
-            coredumpsList =
-                new File('coredumps').openSync(mode: FileMode.APPEND);
-            coredumpsList.writeStringSync(
-                "${test.displayName},${name},${archivedBinaries[binName]}\n");
+            if (unexpectedCrashesFile != null) {
+              unexpectedCrashesFile.closeSync();
+            }
           } catch (e) {
-            print('Failed to add crash to coredumps list: ${e}');
-          } finally {
-            try {
-              if (coredumpsList != null)
-                coredumpsList.closeSync();
-            } catch (e) {
-              print('Failed to close coredumps list: ${e}');
-            }
+            print('Failed to close unexpected-crashes file: ${e}');
           }
         }
       }
     }
   }
 }
 
 class SummaryPrinter extends EventListener {
   final bool jsonOnly;
 
@@ skipping 343 matching lines @@
       return new VerboseProgressIndicator(startTime);
     case 'status':
       return new ProgressIndicator(startTime);
     case 'buildbot':
       return new BuildbotProgressIndicator(startTime);
     default:
       assert(false);
       return null;
   }
 }