Mark Layer Damaged When The Client Is Gone

Mark Layer Damaged When The Client Is Gone

We found a bug that black boxes are seen when hangouts switches focused
participants. It is related to an issue that we did not mark the layer
hosting WebMediaPlayerMS damaged properly. This CL fixed that issue.

BUG=681006
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2692873003
Cr-Commit-Position: refs/heads/master@{#450400}
Committed: https://chromium.googlesource.com/chromium/src/+/867223fdd3327e622cb42836fa1ccc2d66465fec

[qiangchen, 2017-02-13 22:08:08]

Description was changed from

==========
Mark Layer Damaged When The Client Is Gone


Mark Layer Damaged When The Client Is Gone

We found a bug that black boxes are seen when hangouts switches focused
participants. It is related to an issue that we did not mark the layer
hosting WebMediaPlayerMS damaged properly. This CL fixed that issue.

BUG=681006
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2664943002
Cr-Commit-Position: refs/heads/master@{#447811}
Committed:
https://chromium.googlesource.com/chromium/src/+/101569dac2a9cee88240aa87fc69...

patch from issue 2664943002 at patchset 60001
(http://crrev.com/2664943002#ps60001)
==========

to

==========
Mark Layer Damaged When The Client Is Gone

We found a bug that black boxes are seen when hangouts switches focused
participants. It is related to an issue that we did not mark the layer
hosting WebMediaPlayerMS damaged properly. This CL fixed that issue.

BUG=681006
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2664943002
Cr-Commit-Position: refs/heads/master@{#447811}
Committed:
https://chromium.googlesource.com/chromium/src/+/101569dac2a9cee88240aa87fc69...

patch from issue 2664943002 at patchset 60001
(http://crrev.com/2664943002#ps60001)
==========

[qiangchen, 2017-02-13 22:08:08]

qiangchen@chromium.org changed reviewers:
+ danakj@chromium.org

[qiangchen, 2017-02-13 22:08:23]

Description was changed from

==========
Mark Layer Damaged When The Client Is Gone

We found a bug that black boxes are seen when hangouts switches focused
participants. It is related to an issue that we did not mark the layer
hosting WebMediaPlayerMS damaged properly. This CL fixed that issue.

BUG=681006
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2664943002
Cr-Commit-Position: refs/heads/master@{#447811}
Committed:
https://chromium.googlesource.com/chromium/src/+/101569dac2a9cee88240aa87fc69...

patch from issue 2664943002 at patchset 60001
(http://crrev.com/2664943002#ps60001)
==========

to

==========
Mark Layer Damaged When The Client Is Gone

We found a bug that black boxes are seen when hangouts switches focused
participants. It is related to an issue that we did not mark the layer
hosting WebMediaPlayerMS damaged properly. This CL fixed that issue.

BUG=681006
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[danakj, 2017-02-13 23:19:24]

Hey qiangchen,

You didn't publish this but I assume you wanted me to look at this from the bug?
I found it going thru codereview, but I'm not certain. You could also just
reopen the last CL and add your changes as new patchset there.

[danakj, 2017-02-13 23:20:27]

I don't see a test case covering why this CL was originally reverted, can you
add something?

[qiangchen, 2017-02-13 23:54:09]

The CQ bit was checked by qiangchen@chromium.org to run a CQ dry run

[qiangchen, 2017-02-13 23:54:24]

Added a unit test case for Stop()

[commit-bot: I haz the power, 2017-02-13 23:55:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 01:56:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 01:56:59]

Dry run: This issue passed the CQ dry run.

[danakj, 2017-02-14 17:41:53]

LGTM thanks!

[qiangchen, 2017-02-14 17:42:14]

The CQ bit was checked by qiangchen@chromium.org

[commit-bot: I haz the power, 2017-02-14 17:42:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 17:47:16]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487094134028760,
"parent_rev": "0dc1852220e72a4d6c62495db7481239dbbd4375", "commit_rev":
"867223fdd3327e622cb42836fa1ccc2d66465fec"}

[commit-bot: I haz the power, 2017-02-14 17:47:52]

Description was changed from

==========
Mark Layer Damaged When The Client Is Gone

We found a bug that black boxes are seen when hangouts switches focused
participants. It is related to an issue that we did not mark the layer
hosting WebMediaPlayerMS damaged properly. This CL fixed that issue.

BUG=681006
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Mark Layer Damaged When The Client Is Gone

We found a bug that black boxes are seen when hangouts switches focused
participants. It is related to an issue that we did not mark the layer
hosting WebMediaPlayerMS damaged properly. This CL fixed that issue.

BUG=681006
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2692873003
Cr-Commit-Position: refs/heads/master@{#450400}
Committed:
https://chromium.googlesource.com/chromium/src/+/867223fdd3327e622cb42836fa1c...
==========

[commit-bot: I haz the power, 2017-02-14 17:47:53]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/867223fdd3327e622cb42836fa1c...